fixed failing online test - [merged]

[nabobalis]

Merges bugfix -> master

Fixes https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/issues/123

[nabobalis]

added 1 commit

• a2bf6943 - fixed test

Compare with previous version

[nabobalis]

added 1 commit

• 404a37af - fixed test

Compare with previous version

[nabobalis]

added 1 commit

• 1732c9b2 - fixed test and astropy issue

Compare with previous version

[nabobalis]

added 1 commit

• 1d96ae61 - fixed test and astropy issue

Compare with previous version

[nabobalis]

added 1 commit

• d02be3f3 - fixed test and astropy issue

Compare with previous version

[nabobalis]

In GitLab by @codecov on Jan 7, 2022, 10:52

Codecov Report

Merging #148 (e3a41ff) into master (93309b8) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          19       19           
  Lines         606      606           
=======================================
  Hits          581      581           
  Misses         25       25           

Impacted Files	Coverage Δ
aiapy/calibrate/__init__.py	100.00% <100.00%> (ø)
aiapy/psf/__init__.py	100.00% <100.00%> (ø)
aiapy/response/__init__.py	100.00% <100.00%> (ø)
aiapy/util/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93309b8...e3a41ff. Read the comment docs.

[nabobalis]

added 1 commit

• 96ccf2e6 - fixed test and astropy issue

Compare with previous version

[nabobalis]

added 1 commit

• 2fbf1098 - fixed test and astropy issue

Compare with previous version

[nabobalis]

added 1 commit

• 66314faf - fixed test and astropy issue

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 11:51

Commented on aiapy/calibrate/prep.py line 81

I'm fine with this, but this feels like something we should ultimately be addressing upstream in Map.rotate

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 11:54

Commented on aiapy/calibrate/tests/test_meta.py line 32

This can just be a QTable and you can create an array of astropy.time.Time objects from a list of time strings.

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 11:54

Commented on aiapy/calibrate/tests/test_meta.py line 99

These are arcsec. As above, if you just create a QTable directly, no need to inject these later.

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 11:54

Commented on aiapy/calibrate/tests/test_meta.py line 177

This is fine, but update_pointing includes a pointing_table keyword so you don't have to mock anything,

       aia_171_map_updated = update_pointing(aia_171_map, pointing_table=mock_pointing_table)

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 11:54

Commented on aiapy/calibrate/prep.py line 81

Also, why does this fix the issue?

[nabobalis]

scale_factor.value is a masked float, so by floating it, we remove the mask on it and it passes.

I don't really understand it.

[nabobalis]

I took this from the fido search and it was quicker.

[nabobalis]

changed this line in version 10 of the diff

[nabobalis]

changed this line in version 10 of the diff

[nabobalis]

changed this line in version 10 of the diff

[nabobalis]

added 1 commit

• cc8bd00c - code review

Compare with previous version

[nabobalis]

E astropy.units.core.UnitConversionError: 'arcsec' (angle) and 'arcsec / pix' are not convertible

[nabobalis]

Fixed.

[nabobalis]

Fixed.

[nabobalis]

Fixed.

[nabobalis]

Tho the units being arcseconds breaks the test.

[nabobalis]

In GitLab by @wtbarnes on Jan 7, 2022, 14:59

Commented on aiapy/calibrate/tests/test_meta.py line 99

Sorry sorry sorry. It is pixel. Ignore me.

[nabobalis]

changed this line in version 11 of the diff

[nabobalis]

added 1 commit

• 3046e377 - code review

Compare with previous version

[nabobalis]

added 1 commit

• 6bed8c8c - code review

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 14, 2022, 05:38

Commented on aiapy/calibrate/prep.py line 81

Why is scale_factor a masked float?

[nabobalis]

In GitLab by @wtbarnes on Jan 14, 2022, 07:37

Commented on aiapy/calibrate/prep.py line 81

I would revert this change in favor of !151, merge this, and then I'll rebase !151 on top of master

[nabobalis]

Ok.

[nabobalis]

changed this line in version 13 of the diff

[nabobalis]

resolved all threads

[nabobalis]

added 1 commit

• 67318a1e - undo

Compare with previous version

[nabobalis]

added 1 commit

• e3a41ffb - undo

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 14, 2022, 07:42

resolved all threads

[nabobalis]

In GitLab by @wtbarnes on Jan 14, 2022, 07:42

approved this merge request

[nabobalis]

enabled an automatic merge when the pipeline for e3a41ffb0c66723049898810885500ec904e4bbb succeeds

[nabobalis]

canceled the automatic merge

[nabobalis]

In GitLab by @wtbarnes on Jan 14, 2022, 07:51

enabled an automatic merge when the pipeline for e3a41ffb0c66723049898810885500ec904e4bbb succeeds

[nabobalis]

canceled the automatic merge

[nabobalis]

mentioned in commit 079b71fe04def61f99963a2647a07e1f46d8bf88

[nabobalis]

picked the changes into the branch cherry-pick-079b71fe with commit 0c49bf44be61a297cce35197dad485e731b9d8da

[nabobalis]

mentioned in commit 0c49bf44be61a297cce35197dad485e731b9d8da