General Tidy up of docs and fixes to some warning types - [merged]

[nabobalis]

Merges register -> main

All changes that this PR does are documented in the changelog.

Other misc changes have no user facing changes but tidy up RST and CI issues.

[nabobalis]

added 1 commit

• a4d24595 - [Fix?] Pad arrays that are 4094 when registered

Compare with previous version

[nabobalis]

added 1 commit

• 32f1128d - [Fix?] Pad arrays that are 4094 when registered

Compare with previous version

[nabobalis]

added 1 commit

• e9a5474e - test config option for CI

Compare with previous version

[nabobalis]

added 1 commit

• 1c092e2f - update error message and add tests for degradation

Compare with previous version

[nabobalis]

marked this merge request as ready

[nabobalis]

added 3 commits

• 69f2caad - Break API for degradation
• fa015a25 - changelog
• fffec36d - fix tests

Compare with previous version

[nabobalis]

added 1 commit

• 2daf12a9 - pad with fill value

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 12, 2023, 11:11

Commented on aiapy/calibrate/prep.py line 97

I think I am :thumbsdown: on this approach. Is there a particular reason that level 1.5 maps must always have dimensions (4096,4096)? Is this just to maintain consistency with what is done in IDL? (that is fine if that is the case).

If so, I think instead of special casing some particular shape, we should have some sort of cropping/padding operations that ensures that the centered, de-rotated, and scaled image always has a width and height of 4096 pixels.

[nabobalis]

In GitLab by @wtbarnes on Jan 12, 2023, 11:15

Commented on aiapy/calibrate/prep.py line 82

(This does not really relate to the changes made in this PR)

I don't think this if-else block is needed. The target scale should always be 0.6 "/pixel

    scale = 0.6 * u.arcsec

This function should also only be applied to level 1 maps (which by definition have not been rescaled).

[nabobalis]

I actually don't know what the IDL version does. I should check.

Is it possible to do that generally to ensure the image is always 4096?

[nabobalis]

I will remove it.

[nabobalis]

In GitLab by @wtbarnes on Jan 12, 2023, 12:36

Commented on aiapy/calibrate/prep.py line 97

Ha well with my proposed padding approach in submap it will be :stuck_out_tongue:. Otherwise, no, I don't think so (not without reprojection at least).

[nabobalis]

Ok, so I will remove this then. Add a note in the doc string or something.

[nabobalis]

changed this line in version 8 of the diff

[nabobalis]

changed this line in version 8 of the diff

[nabobalis]

added 1 commit

• a9899652 - What a mess

Compare with previous version

[nabobalis]

Now removed.

[nabobalis]

Removed, added a warning to the docstring.

[nabobalis]

added 1 commit

• e046c4a5 - What a mess

Compare with previous version

[nabobalis]

added 1 commit

• a4e70edb - What a mess

Compare with previous version

[nabobalis]

added 1 commit

• 00317003 - What a mess

Compare with previous version

[nabobalis]

added 1 commit

• 4cc39534 - What a mess

Compare with previous version

[nabobalis]

added 1 commit

• dc312617 - What a mess

Compare with previous version

[nabobalis]

added 1 commit

• 7df375a5 - What a mess

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 13, 2023, 06:56

Sorry, but the scope of this PR has now become unclear to me and I'm having a hard time reviewing it. Could you move all the register-related commits to a separate PR? Or if it is easier, just remove them. If the latter, I can open a separate PR to deal with my suggested changes.

I think it is important to keep any changes to register in their own PRs and not buried amongst other changes, given its importance in the "prep" phase of analyzing AIA data.

[nabobalis]

This PR now does 0 actual changes to register.

[nabobalis]

added 1 commit

• b14323fe - update changelog

Compare with previous version

[nabobalis]

added 1 commit

• 3ff4b6dd - update changelog

Compare with previous version

[nabobalis]

I updated the changelog to say that this PR does.

[nabobalis]

added 1 commit

• a1ab7498 - undo change to regsiter

Compare with previous version

[nabobalis]

This has been reverted now.

[nabobalis]

resolved all threads

[nabobalis]

In GitLab by @wtbarnes on Jan 17, 2023, 11:52

Commented on aiapy/calibrate/tests/test_prep.py line 37

I would keep this comment. It links to the issue that explains why this is not checking for 4096

[nabobalis]

In GitLab by @wtbarnes on Jan 17, 2023, 11:55

approved this merge request

[nabobalis]

changed this line in version 18 of the diff

[nabobalis]

added 1 commit

• b9298a05 - Added back comments in unit test

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Jan 17, 2023, 11:55

resolved all threads

[nabobalis]

mentioned in commit 8a23c715b552d0024f5421b3d76152c00a50c9ba