search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix API inconsistency in sample data downloader - [merged] #305

Closed nabobalis closed 8 months ago

nabobalis commented 10 months ago

In GitLab by @wtbarnes on Sep 1, 2023, 17:53

Merges fix-sample-data-download -> main

This fixes a bug where the header keyword argument in the parfive.Downloader is now passed as config.

nabobalis commented 10 months ago

In GitLab by @wtbarnes on Sep 1, 2023, 17:55

added 1 commit

Compare with previous version

nabobalis commented 10 months ago

In GitLab by @wtbarnes on Sep 1, 2023, 18:00

enabled an automatic merge when the pipeline for 9191828bdc20255ee309694f28b9d08ee6753504 succeeds

nabobalis commented 10 months ago

In GitLab by @codecov on Sep 1, 2023, 18:03

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.01% :tada:

Comparison is base (cd94874) 93.75% compared to head (9191828) 93.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== + Coverage 93.75% 93.77% +0.01% ========================================== Files 20 20 Lines 657 659 +2 ========================================== + Hits 616 618 +2 Misses 41 41 ``` | [Files Changed](https://app.codecov.io/gl/LMSAL_HUB:aia_hub/aiapy/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=AIA+HUB) | Coverage Δ | | |---|---|---| | [aiapy/data/\_sample.py](https://app.codecov.io/gl/LMSAL_HUB:aia_hub/aiapy/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=AIA+HUB#diff-YWlhcHkvZGF0YS9fc2FtcGxlLnB5) | `57.69% <75.00%> (+1.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nabobalis commented 10 months ago

In GitLab by @wtbarnes on Sep 1, 2023, 18:07

mentioned in commit b15a12d728d287dd646d0ee0698ac218f67218a5

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:45

picked the changes into the branch cherry-pick-b15a12d7 with commit 6a0240f2d551f9ac886fae370c190387876d4f0d

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:45

mentioned in commit 6a0240f2d551f9ac886fae370c190387876d4f0d

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:54

mentioned in commit 9852ab11f4c91e0b4137f5560c00d9d9a0b12c51

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:54

mentioned in commit 96fb6f419e337be014916e4921c83e9761442b29