LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Backport !181 to 0.7 - [merged] #308

Closed nabobalis closed 8 months ago

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:48

Merges cherry-pick-b15a12d7 -> 0.7

Fix API inconsistency in sample data downloader

See merge request LMSAL_HUB/aia_hub/aiapy!181

(cherry picked from commit b15a12d728d287dd646d0ee0698ac218f67218a5)

f5554a54 fix API inconsistency in sample data downloader 9191828b fix another API consistency

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:48

enabled an automatic merge when the pipeline for 6a0240f2d551f9ac886fae370c190387876d4f0d succeeds

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:53

approved this merge request

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:53

canceled the automatic merge

nabobalis commented 8 months ago

In GitLab by @codecov on Oct 31, 2023, 12:53

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1b0a38a) 93.75% compared to head (6a0240f) 93.77%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.7 #184 +/- ## ========================================== + Coverage 93.75% 93.77% +0.01% ========================================== Files 20 20 Lines 657 659 +2 ========================================== + Hits 616 618 +2 Misses 41 41 ``` | [Files](https://app.codecov.io/gl/LMSAL_HUB:aia_hub/aiapy/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=AIA+HUB) | Coverage Δ | | |---|---|---| | [aiapy/data/\_sample.py](https://app.codecov.io/gl/LMSAL_HUB:aia_hub/aiapy/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=AIA+HUB#diff-YWlhcHkvZGF0YS9fc2FtcGxlLnB5) | `57.69% <75.00%> (+1.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nabobalis commented 8 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:54

mentioned in commit 96fb6f419e337be014916e4921c83e9761442b29