search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Use DN instead of counts everywhere #338

Closed wtbarnes closed 4 months ago

wtbarnes commented 4 months ago

In line with sunpy/sunpy#7585, this replaces the usage of ct/count with DN everywhere. This may cause some friction in terms of compatibility with sunpy as prior to v6, the units of any AIA map are converted to ct rather than DN. I'm not sure the best way to resolve that. We could of course just pin to >= v6, but that seems aggressive.

nabobalis commented 4 months ago

Consider this a breaking change? We can do a 0.9 release for it.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (c3bd709) to head (37225e0).

Files Patch % Lines
aiapy/response/tests/test_channel.py 0.00% 6 Missing :warning:
aiapy/calibrate/uncertainty.py 66.66% 1 Missing :warning:
aiapy/response/channel.py 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (c3bd709) and HEAD (37225e0). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (c3bd709) | HEAD (37225e0) | |------|------|------| ||4|3|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #338 +/- ## =========================================== - Coverage 86.84% 69.72% -17.13% =========================================== Files 34 34 Lines 1209 1209 =========================================== - Hits 1050 843 -207 - Misses 159 366 +207 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wtbarnes commented 4 months ago

Consider this a breaking change? We can do a 0.9 release for it.

Yes, I would say so

nabobalis commented 4 months ago

I think a breaking changelog and its good to go.

wtbarnes commented 4 months ago

The docs build is failing,

/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/calibrate/prep.py:docstring of aiapy.calibrate.prep.degradation:1: WARNING: py:class reference target not found: Unit
/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/calibrate/uncertainty.py:docstring of aiapy.calibrate.uncertainty.estimate_error:1: WARNING: py:class reference target not found: Unit
/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/calibrate/uncertainty.py:docstring of aiapy.calibrate.uncertainty.estimate_error:1: WARNING: py:class reference target not found: Unit
/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/psf/psf.py:docstring of aiapy.psf.psf.psf:1: WARNING: py:class reference target not found: Unit
/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/response/channel.py:docstring of aiapy.response.channel.Channel:1: WARNING: py:class reference target not found: Unit
/home/runner/work/aiapy/aiapy/.tox/build_docs/lib/python3.12/site-packages/aiapy/util/util.py:docstring of aiapy.util.util.telescope_number:1: WARNING: py:class reference target not found: Unit

and I've not worked out why yet.

nabobalis commented 4 months ago

Just add it to the nickpicky list.

wtbarnes commented 4 months ago

Why do I always forget this…

nabobalis commented 4 months ago

We will pin the new version to sunpy 6.0 :P