Open wtbarnes opened 2 months ago
This pull request refactors the Channel
class to inherit from AbstractChannel
in sunkit-instruments
. The changes aim to enable easier calculation of temperature response functions. The refactoring introduces new properties and methods, modifies existing ones, and updates the effective area calculation to include degradation and crosstalk effects.
Change | Details | Files |
---|---|---|
Refactor Channel class to inherit from AbstractChannel |
|
aiapy/response/channel.py |
Modify effective area calculation |
|
aiapy/response/channel.py |
Remove and replace methods |
|
aiapy/response/channel.py |
Update property names and implementations |
|
aiapy/response/channel.py |
This is a first attempt at refactoring the
Channel
class on top of theAbstractChannel
class fromsunkit-instruments
. The latter is still in the form of a draft PR sunpy/sunkit-instruments#98 so this is an experimental PR at this stage.The goal here is to easily enable calculating the temperature response functions.
As it stands, this represents a breaking change to the
Channel
API.ToDos before this can be merged:
sunkit-instruments
release includingAbstractChannel
Summary by Sourcery
Refactor the
Channel
class to extendAbstractChannel
, enhancing the API with additional parameters and methods for more flexible and accurate temperature response function calculations. This change introduces a breaking change to theChannel
API.Enhancements:
Channel
class to inherit fromAbstractChannel
, introducing a more structured approach to handling channel properties and response functions.Channel
class constructor, includinginclude_eve_correction
,include_crosstalk
,correction_table
, andcalibration_version
, to enhance flexibility in response function calculations.primary_reflectance
toprimary_mirror_reflectance
andfocal_plane_filter_efficiency
tofocal_plane_filter_transmittance
.mirror_reflectance
,filter_transmittance
, andenergy_per_electron
.