search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Degradation should accept astropy.time.Time objects of length greater than 1 #66

Closed nabobalis closed 10 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 17, 2020, 08:51

aiapy.calibrate.degradation takes a channel and an obstime as an input and currently obstime can only be of length 1. This is somewhat annoying if you're trying to compute the degradation over a range of times because it means you have to call the function repeatedly in a loop (see the degradation gallery example). It would be better if this function accepted a astropy.time.Time object of length > 1.

The current difficulty is due to the selections from the calibration table. We would need to work out how to select rows from the table given an array of obstimes.

This could be as simple as wrapping the logic in degradation in a loop and repeatedly calling _select_epoch_from_table

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 17, 2020, 13:54

mentioned in commit 2052dab6cf82b3d93e9152d61e7f866f9710dd50