Open nabobalis opened 3 years ago
In GitLab by @wtbarnes on Nov 12, 2020, 11:10
Oof ok. I'm not terribly surprised that this is an issue. The checking that we do to make sure that the spike is still within the FOV for a cropped map is pretty rudimentary: https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/blob/master/aiapy/calibrate/spikes.py#L176
I wonder why this falls inside the FOV in pixel space but not in world space.
We should probably have a test that covers these kinds of edge cases.
In GitLab by @wtbarnes on Apr 30, 2021, 05:41
changed health status to needs attention
In GitLab by @hayesla on Nov 12, 2020, 10:54
I have found an issue when a spike coordinate lies near the edge of a submap. For example:
e.g.
if we inspect this - looking at the
spike_coords
one of the coordinates returned is outside of map range (see 1000.37''):It's only an issue near the border - for example if you change the
top_right
coordinate to be1001*u.arcsec
it works fine. I guess its an issue of edge cases and finding closest pixel.