search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Deprecation warnings from sunpy 2.1 #83

Closed nabobalis closed 10 months ago

nabobalis commented 3 years ago

In GitLab by @dstansby1 on Jan 7, 2021, 08:35

I accidentally ran aiapy with the current development version of sunpy, and got these warnings:

WARNING: SunpyDeprecationWarning: specify desired keywords as arguments to JSOCResponse.show() [aiapy.calibrate.util]
WARNING: SunpyDeprecationWarning: use JSOCClient.search() instead [aiapy.calibrate.util]

I think they're coming from aiapy, so it would be good to fix them.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 20, 2021, 19:23

I think !99 should address the second warning.

For the first, I think it is a matter of removing the keys kwarg from one of the JSOCClient.search calls.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Apr 30, 2021, 05:41

changed health status to needs attention

nabobalis commented 3 years ago

In GitLab by @wtbarnes on May 24, 2021, 12:53

mentioned in commit 247ddf883497a3ea6c23534de5a81cef4a954f5b