search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Whether aiapy.psf uses the GPU/cupy or not is opaque #84

Open nabobalis opened 3 years ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Feb 2, 2021, 08:50

Currently, in aiapy.psf.psf and aiapy.psf.deconvolve, cupy is used if it is installed and if use_gpu is set to True. This is a bit opaque to users and is somewhat dangerous as it potentially means a result is dependent on someone's environment and this may be very non-obvious.

Perhaps a better solution should be to use cupy only if the input map data is a cupy array. This would make it much more clear to users they are using cupy. This is slightly more tricky for the PSF calculation as there is no input array, but maybe the current interface would suffice for that function.

This may also require an upstream fix in sunpy that allows map data to be a cupy array.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Apr 30, 2021, 05:41

changed health status to needs attention