search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Pin sunpy dependency to >=2.1 #86

Closed nabobalis closed 11 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Apr 30, 2021, 06:07

Before merging !99 and !97, we need to pin our sunpy dependency to 2.1. A 3.0 release is coming in the next few weeks so this is not an unreasonable minimum version. Until a 1.0 release for aiapy, I don't think we need to stress too much about what versions of packages we do/don't support

nabobalis commented 3 years ago

In GitLab by @wtbarnes on May 12, 2021, 18:23

There should be an intermediate release, perhaps 5.1, that pins aiapy to <=3.0. Once 3.1 is released, !99 and !97 should be merged and #103 resolved

nabobalis commented 3 years ago

In GitLab by @wtbarnes on May 13, 2021, 11:50

As an amendment to the previous comment, I'm going to suggest backporting the pin to <=3.0 to the 0.5 branch, doing a 0.5.1 release, and then making 0.6 compatible with >= 3.1. We can continue backporting bug fixes to the 0.5 branch as needed.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on May 24, 2021, 13:01

Closed by !111 and !99