search

LMAOboxhack / pe

0 stars 0 forks source link

DG UI component class diagram is too complicated #12

Open LMAOboxhack opened 2 years ago

LMAOboxhack commented 2 years ago

Steps to reproduce:

  1. Go to the UI component section of the DG.

Expected: If diagrams have too many details, unimportant details can be omitted for better readability.

Actual: Too many interactions, overcomplicated diagram, hard for developer to follow. Consider omitting the inheritance to the UiPart abstract class.

image.png

nus-pe-bot commented 2 years ago

Team's Response

This will only cause minor inconveniences to developers. We agree that it would have been possible to omit the UiPart inheritance, but the relationships between the objects (as depicted by the arrows) are still clear and unambigious. Besides, we discuss the inheritance in the DG, so we felt that it would be necessary to include it here.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]