search

LMAOboxhack / pe

0 stars 0 forks source link

Duplicate lessons can be added to a module #5

Open LMAOboxhack opened 3 years ago

LMAOboxhack commented 3 years ago

Steps to reproduce:

  1. Open the details view of any module.
  2. Add a lesson to a module, e.g. add lesson n/Weekly Lab d/Monday s/1000 e/1100
  3. Add the same exam, but with a name in lower case, i.e. add lesson n/Weekly lab d/Monday s/1000 e/1100 or with an extra space, i.e. add lesson n/Weekly (extra space) Lab d/Monday s/1000 e/1100

Expected: A user would expect 'Weekly Lab' to be the same lesson as 'Weekly lab' or 'Weekly (extra space) Lab'. Repeating the command stated in step 2 above yields an error message warning about duplicate lessons as well, so a user would expect to be warned about accidentally entering a duplicate lesson.

Actual: The duplicate lesson is added as per normal. (See lesson 4 & 5)

image.png

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate exams can be added to a module

Steps to reproduce:

  1. Open the details view of any module.
  2. Add an exam to a module, e.g. add exam n/Final Exam d/31/12/2022 s/2100 e/2200 v/MPSH
  3. Add the same exam, but with a name in lower case, i.e. add exam n/final Exam d/31/12/2022 s/2100 e/2200 v/MPSH or with an extra space, i.e. add exam n/Final (extra space) Exam d/31/12/2022 s/2100 e/2200 v/MPSH

Expected: A user would expect 'Final Exam' to be the same exam as 'Final exam' or 'Final (extra space) Exam'. Repeating the command stated in step 2 above yields an error message warning about duplicate exams as well, so a user would expect to be warned about accidentally entering a duplicate exam.

Actual: The duplicate exam is added as per normal. (See Exams 5 & 6)

image.png

[original: nus-cs2103-AY2122S1/pe-interim#656] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This will appear only in very rare situations when the user forgets that he already added an exam and then attempt to create the exact same exam with an extra space or different casing. Even if this happens, this causes a minor inconvenience only since the user will just have to delete the duplicated exam.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Not sure if this is a duplicate, since Lessons and Exams are separate entities. From 'Guidelines for Bug Triaging', the following is considered as a duplicate:

Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently

In this case, this would require Lessons and Exams to be fixed independently.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]