search

LMAOboxhack / pe

0 stars 0 forks source link

Valid exam time slot causes error #6

Open LMAOboxhack opened 2 years ago

LMAOboxhack commented 2 years ago

Steps to reproduce:

  1. Open the detail view for a module.
  2. Add an exam from 9pm to 12am, e.g. add exam n/Final Exam d/31/12/2022 s/2100 e/0000 v/MPSH

Expected: Exam is added as per normal.

Actual: App displays error message that 'start time should be before end time'

image.png

nus-pe-bot commented 2 years ago

Team's Response

0000 is intepreted as the start of the day, so the end time input is indeed earlier than the start time.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: 0000 is given only as an example; this may be a case of overzealous input validation. There are cases where an exam's end time may be earlier than its start time, e.g. IS1103's final assessment spans an entire week. In such cases, a user might want to keep track of the exam opening time & submission deadline, and run into the case where the deadline occurs earlier in the day than the opening time. Hence, it might be better to warn the user instead of simply blocking the input, as stated under 'Guidelines for bug triaging' on the website.