search

LMAOboxhack / pe

0 stars 0 forks source link

Valid lesson time slot causes error #7

Open LMAOboxhack opened 2 years ago

LMAOboxhack commented 2 years ago

Steps to reproduce:

  1. Open the detail view for a module.
  2. Add a lesson from 9pm to 12am, e.g. add lesson n/Weekly Lab d/Monday s/2100 e/0000

Expected: Lesson is added as per normal.

Actual: App displays error message that 'start time should be before end time'

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Valid exam time slot causes error

Steps to reproduce:

  1. Open the detail view for a module.
  2. Add an exam from 9pm to 12am, e.g. add exam n/Final Exam d/31/12/2022 s/2100 e/0000 v/MPSH

Expected: Exam is added as per normal.

Actual: App displays error message that 'start time should be before end time'

image.png

[original: nus-cs2103-AY2122S1/pe-interim#660] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

0000 is intepreted as the start of the day, so the end time input is indeed earlier than the start time.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: As mentioned in another response:

Not sure if this is a duplicate, since Lessons and Exams are separate entities. From 'Guidelines for Bug Triaging', the following is considered as a duplicate:

Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently

In this case, this would require Lessons and Exams to be fixed independently.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Similar to another response:

0000 is given only as an example; this may be a case of overzealous input validation. There are cases where a user might want to specify avoid specifying a timeslot as defined in the app, e.g. some e-learning modules like CFG-coded modules have lessons without a specific timeslot. In such as case, the user might wish to specify a dummy timeslot, e.g. start & end 0000, or better still not even specify one at all (in this app it is a compulsory field). Hence, it might be better to warn the user instead of simply blocking the input, as stated under 'Guidelines for bug triaging' on the website.