LMAOboxhack / pe

0 stars 0 forks source link

Editing a module does not indicate how the module was edited #8

Open LMAOboxhack opened 2 years ago

LMAOboxhack commented 2 years ago

Steps to reproduce:

  1. From the modules view, edit an existing module's name. e.g. edit 6 n/another name

Expected: The user is shown a message that tells them how the module was updated (e.g. Name changed from (previous) to (current))

Actual: The message only displays which module was edited, and not how the module was changed.

image.png

nus-pe-bot commented 2 years ago

Team's Response

There is no justification provided to indicate that this is a critical feature. However, we believe is a good suggestion for the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: From 'Guidelines for bug triaging':

Similarly, if the feature is implemented to work in a certain way but it could have been implemented to work in a better way (from the end-user's point of view) without much additional effort, it should be accepted as a type.FeatureFlaw, and cannot be categorized as response.NotInScope.

I believe this fits the description, as a user would certainly want to see a confirmation message of how they edited a module, instead of the current "edited module XXXX" message, which may leave a user unsure about their command's effect. This can be implemented without much additional effort (e.g. Formatting the user's command to a more readable format & printing it along with the original success message).