- & _ is not allowed in latest devbuild, the support was been added in last release

[itsme-to]

Description of Bug

In the latest devbuild, you can't use anymore _ & - inside quest id. It's maybe related to that commit, https://github.com/LMBishop/Quests/commit/aea66501e1019162bb670aa0f97761f637bae847

The support of - and _ was added on this one https://github.com/LMBishop/Quests/commit/a184e76053aa55df4fb5f156fa6c5c0ecb8f811d

Steps to Reproduce

Use the latest devbuild and try to create a quest with _ or - in the name

Environment

• Minecraft version: 1.19.4
• Server software: Paper
• Quests version: Devbuild from github

Agreements

• [X] I am running the latest version of Quests
• [X] I am certain this issue is unique and a similar issue is not currently open
• [X] I am using a version of Minecraft which is supported by Quests

Other

No response

[itsme-to]

@svaningelgem if you want to make this really nice feature back again <3

[Krakenied]

_ can't be supported because it wont work with placeholders

[itsme-to]

_ can't be supported because it wont work with placeholders I see, so - will work ?

[svaningelgem]

_ can't be supported because it wont work with placeholders

Is it possible to get a bit of insight on how this placeholders work together with _? So I can maybe think of another way around it (if at all possible)?

[itsme-to]

Yeah don't working fine currently

[Krakenied]

placeholder API hook uses _ delimiter for splitting

[Krakenied]

maybe - can be supported safely, i need to check that though

[itsme-to]

maybe - can be supported safely, i need to check that though

Yes, without too much trouble, and it's still much simpler visually.

It's way better

[itsme-to]

In the latest release, Papi placeholders work well with -, so it's really just the check that's causing issues in the latest dev build.

[Krakenied]

Ill try implementing it in a more proper way

[Krakenied]

Currently I will give you a temporary fix, however it still needs to be fixed in a more proper way so we can allow _ usage as well lol artifacts.zip

[itsme-to]

Great it's work fine, can you add it to the dev build ? So my client can use it as well ?

[itsme-to]

Oh great, I didn't see it

[t4ba]

possible to add _ back ?

[Krakenied]

possible to add _ back ?

But there is no way to make it work properly with placeholders