LMFDB / lmfdb

L-Functions and Modular Forms Database
Other
246 stars 199 forks source link

errors in modular form data #1223

Closed jwbober closed 8 years ago

jwbober commented 8 years ago

_1 Upvote_ I have been trying to match modular form data in the LMFDB with data that I computed myself, so a few days ago I grabbed all of the complex embeddings of the q-expansions of all of the modular forms in the LMFDB. Below is a list of 1080 forms with weight between 2 and 12, and level < 100, that I have had trouble matching with my data.

This is not necessarily a comprehensive list of errors, and it is even possible that some of the forms in this list are fine, and I hope I am wrong about how much is wrong (possibly many of the cases with level < 50 have been fixed by now) but every form that I have manually examined has turned out to have problems. In some of them a9 is wrong for some reason. In at least two cases there are rational forms with the wrong coefficients. I think in another case there is a form that looks rational but shouldn't be. In other cases the page or the space gives an error, but maybe it can be clicked on. For others the page or space says it is not in the database.

Here is the list: boberlist.txt

jvoight commented 8 years ago

@jwbober : Can you do a first attempt to separate these out by the actual issue? (Whatever you're doing to check, you can sort them by the problem, right?)

Starting from the top...

10.11.7.b, 10.11.7.c: this means that the form is level 10 and weight 11, right? I agree this form is not in the database, but it's not advertised as being there. http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/10/11/?group=1

10.12.9.a: This one appears http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/10/12/9/a/ When I compute it using Magma, the coefficients a_9, a_18 are indeed wrong. And the L-function looks ridiculous.

Let's break this up into cases.

sehlen commented 8 years ago

Please note that Fredrik mentioned before that probably all of these that have problems are related to an error in a previous version of the code and it is not an accident that a(9) has a problem because it was an error in the routine computing the coefficients recursively from the a_p's. The code is fixed but there have been many problems with the database connection when Fredrik tried to fix them so he was not able to do so and is now "offline".

On Sat, 7 May 2016 at 14:06 jvoight notifications@github.com wrote:

@jwbober https://github.com/jwbober : Can you do a first attempt to separate these out by the actual issue? (Whatever you're doing to check, you can sort them by the problem, right?)

Starting from the top...

10.11.7.b, 10.11.7.c: this means that the form is level 10 and weight 11, right? I agree this form is not in the database, but it's not advertised as being there. http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/10/11/?group=1

10.12.9.a: This one appears http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/10/12/9/a/ When I compute it using Magma, the coefficients a_9, a_18 are indeed wrong. And the L-function looks ridiculous.

Let's break this up into cases.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217656738

jwbober commented 8 years ago

When I do the same comparison but only use a1 through a8 I get fewer errors, but I still get a list of 600. I will go through this list and try to produce examples of various problems that come up.

I got my list of forms by manually querying the database by modifying some code Fredrik sent me. I don't know why in some cases I found a form in the database but the space of forms is not available from the website.

sehlen commented 8 years ago

On May 7, 2016, at 14:40, Jonathan Bober notifications@github.com wrote:

When I do the same comparison but only use a1 through a8 I get fewer errors, but I still get a list of 600. I will go through this list and try to produce examples of various problems that come up.

I got my list of forms by manually querying the database by modifying some code Fredrik sent me. I don't know why in some cases I found a form in the database but the space of forms is not available from the website.

That’s because errors occurred when inserting the data, I guess or not all hecke orbits have been computed yet which is an indication that something has gone wrong when Fredrik computed them.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217660945

jwbober commented 8 years ago

From http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/93/2/ I can click to reach the space http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/93/2/16/, but that page produces a server error.

jwbober commented 8 years ago

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/58/2/57/ just has completely wrong coefficients. It should start

q + a0_q^2 + a0_q^3 - q^4 + q^5 - q^6 - 2_q^7 - a0_q^8 + 2*q^9 + O(q^10)

(where a0^2 = 1, so at least the number field is correct.)

JohnCremona commented 8 years ago

93/2/16 looks fine after #1222 which I am checking now.

JohnCremona commented 8 years ago

I find it very hard to believe that a_9 is not computed correctly. Don't we use standard Sage for the one-off computations of data to be inserted?

JohnCremona commented 8 years ago

@jwbober Sorry to be devil's advocate but why should we believe that your own data is correct? Is it just the computation of a_n for composite n which we have wrong in the database?

jwbober commented 8 years ago

It is not all composite n. For 93/2/16 there is a problem with a4, but a9 is correct. I will see what happens when I try to run comparisons using just prime coefficients.

For http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/58/2/57/, I copy-and-pasted Sage output, which agrees with what I've computed.

I'm pretty sure that my data is correct, because Dave Platt has verified the Riemann Hypothesis at small height for all of it. The comparisons I'm making do have some problems, though. For example, I notice now that some spaces don't have all of the Galois orbits in the LMFDB, which will mess up the comparisons I've made.

JohnCremona commented 8 years ago

Good answer!

sehlen commented 8 years ago

@fredstro: This one is very strange. The eigenvalues record is very old - it has been computed with sage 5.0beta7 and I thought you replaced all old records at some point...

On Sat, 7 May 2016 at 14:52 Jonathan Bober notifications@github.com wrote:

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/58/2/57/ just has completely wrong coefficients. It should start

q + a0_q^2 + a0_q^3 - q^4 + q^5 - q^6 - 2_q^7 - a0_q^8 + 2*q^9 + O(q^10)

(where a0^2 = 1, so at least the number field is correct.)

— You are receiving this because you were assigned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217661564

sehlen commented 8 years ago

@fredstro We have to trace back all of these data issues to their source but I can't do that alone and I have to stop working on this now until Sunday evening.

On Sat, 7 May 2016 at 15:26 Stephan Ehlen stephan.j.ehlen@gmail.com wrote:

@fredstro: This one is very strange. The eigenvalues record is very old - it has been computed with sage 5.0beta7 and I thought you replaced all old records at some point...

On Sat, 7 May 2016 at 14:52 Jonathan Bober notifications@github.com wrote:

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/58/2/57/ just has completely wrong coefficients. It should start

q + a0_q^2 + a0_q^3 - q^4 + q^5 - q^6 - 2_q^7 - a0_q^8 + 2*q^9 + O(q^10)

(where a0^2 = 1, so at least the number field is correct.)

— You are receiving this because you were assigned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217661564

JohnCremona commented 8 years ago

Is it possible that when we made the big switchover to the new modular form database format, some of the old-style forms were left in and hence not recomputed and are now causing trouble?

I may be speaking nonsense,

It is not hard to write a script to go through a collection and delete all items created before (or after) a certain data. the mongo _id field knows a lot about where it came from.

sehlen commented 8 years ago

I don't think this is possible because the "old" database is so different that it is simply incompatible. But we started working on this new format a long while ago. Anyway, I think @fredstro has to say something about it because he computed ALL of this data. In the end we could just delete all records that look suspicious.

On Sat, 7 May 2016 at 15:30 John Cremona notifications@github.com wrote:

Is it possible that when we made the big switchover to the new modular form database format, some of the old-style forms were left in and hence not recomputed and are now causing trouble?

I may be speaking nonsense,

It is not hard to write a script to go through a collection and delete all items created before (or after) a certain data. the mongo _id field knows a lot about where it came from.

— You are receiving this because you were assigned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217663611

JohnCremona commented 8 years ago

Yes -- missing data is better than wrong data. And you & Fredrik do have scripts which run over ranges and computes & inserts missing newforms, I think?

jwbober commented 8 years ago

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/15/5/11/ is another example that is completely wrong, as I can confirm with Sage. (it does not even have the correct dimension).

I am going to stop looking at these one example at a time, and instead take the time to rewrite my comparison script to be a bit better. (And instead of trying to find the form in the LMFDB that looks like one of my forms, I will do it the other way around.)

AndrewVSutherland commented 8 years ago

If I got to http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/ I see the q-expansion for 3.37.2.b up to O(q^10), but if then click on http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/b I just see q+\alpha*q^2. Is that as intended?

sehlen commented 8 years ago

In this case you have to scroll down ;-)

That’s more of a user interface issue but, honestly, for forms like this I’m not sure if displaying the q-expansion is of any use to anyone

On May 7, 2016, at 15:54, AndrewVSutherland notifications@github.com wrote:

If I got to http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/ http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/ I see the q-expansion for 3.37.2.b up to O(q^10), but if then click on http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/ http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/ I just see q+\alpha*q^2. Is that as intended?

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217665174

AndrewVSutherland commented 8 years ago

+1 We need an automated way to verify the q-expansions we are displaying and we should remove all the incorrect entries from the database (if/when then can be recreated and independently verified, they can go back in). We risk getting badly burned if we go live with all this bad data.

On 2016-05-07 15:46, Jonathan Bober wrote:

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/15/5/11/ is another example that is completely wrong, as I can confirm with Sage. (it does not even have the correct dimension).

I am going to stop looking at these one example at a time, and instead take the time to rewrite my comparison script to be a bit better. (And instead of trying to find the form in the LMFDB that looks like one of my forms, I will do it the other way around.)


You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217664815

AndrewVSutherland commented 8 years ago

@sehlen my bad :). I agree this is a user interface issue that is not critical. There are others, btw, for example the bread you see on http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/b does not include an entry for http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2.

sehlen commented 8 years ago

On May 7, 2016, at 16:03, AndrewVSutherland notifications@github.com wrote:

@sehlen https://github.com/sehlen my bad :). I agree this is a user interface issue that is not critical. There are others, btw, for example the bread you see onhttp://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/b http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2/b does not include an entry for http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2 http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/3/73/2.

I think it does for me if you mean … but I see now that the word “character” is omitted.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217665626

AndrewVSutherland commented 8 years ago

@sehlen Actually what I should have said is that I think there should be a terminal 'b', i.e. the bread should show the complete path to this page (and also it would be better to either have the word character in both pages or neither, I would vote for neither).

sehlen commented 8 years ago

Good point, @AndrewVSutherland and easy to fix.

On May 7, 2016, at 16:14, AndrewVSutherland notifications@github.com wrote:

@sehlen https://github.com/sehlen Actually what I should have said is that I think there should be a terminal 'b', i.e. the bread should show the complete path to this page (and also it would be better to either have the word character in both pages or neither, I would vote for neither).

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217666140

sehlen commented 8 years ago

@jwbober You have a few forms in here with trivial character. I checked the first few by hand and couldn't see a problem but then I'm not a machine. Could you maybe double check all those with trivial character and if there are in fact no issues (or only a few that we can fix easily), we should simply hide all non-trivial characters for Tuesday and I can spend the next week at AIM working on them and on data quality etc. instead of caring about new things to bring into the lmfdb, which I was supposed to do. Maybe some people would like to join me...

AndrewVSutherland commented 8 years ago

+1 I think this is a very good idea.

jvoight commented 8 years ago

It's definitely "less bad" to hide wrong data than to display it, so if we are confident with Gamma_0, then I vote that we hide just Gamma_1 for Tuesday until the data can be verified.

It's extremely important to get the MF to stand up straight in LMFDB. Even for new things: I can't compute base change HMFs, we can't match genus 2 curves of GL_2-type, etc., until classical MFs is stable and correct. I'd strongly encourage some subset of people to focus 100% on this next week.

To "certify" the data, in addition to checking it using other sources, it would be nice to see the functional equation of the L-function certified in a couple of different ways--that's not a proof, but it's close to a gold standard.

AndrewVSutherland commented 8 years ago

@jvoight Even for Gamma_0 there are still a few issues, e.g. the silently omitted Hecke orbits 49.12.1.c and 49.8.1.d noted in https://github.com/LMFDB/lmfdb/issues/1217. I'd feel better if we could run an automated check on as much as the data as we can before Tuesday (even if it's just for the rational coefficient field cases).

jwbober commented 8 years ago

@sehlen It looks like http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/79/12/1/a/ occurs on my list because the embedding is not precise enough. I haven't verified that the coefficients are correct, but at least some digits of these ridiculously huge numbers are correct for a3. However, the 32nd embedding (at least) should be -211.15284..., but instead is -242.8339... (which is exactly what I get with Sage when I try to compute the embedding using only 53 bits of precision).

This is just the first trivial character that I looked by hand. I'm running a better comparison with what I have now. (But there are some cases where I don't have data, e.g. I have nothing of my own for weight > 12.)

fredstro commented 8 years ago

The problems Bober found indeed has different reasons which I found on Thursday when I was made aware of them. 1) forms which were recomputed during a couple of weeks or so before the Bristol workshop where there was a bug because the character was missing in the recursive formula. This formula is not called from sage since it is not possible without the overhead of constructing ambient hecke modules etc. but rather copied from the source. Because of problems when forms tgat were computed with earlier versions of sage had coefficients in a different but isomorphic number field I had to go into this code and manually coerce coefficients and characters to a field where they can be multiplied. The bug was introduced when I did that. 2) Forms which were constructed from wrong "basic data" I. e. the bases and aps stored in another database. The "wrongness" here is of two types, either the aps are introduced with the wrong number (for instance a(2) is replaced by a(101) etc due to a system with coefficients stored in batches (1-100 and 100-1000 etc.) where the files were parsed wrongly. The other types of mistakes came from the time we switched to Conrey numbering. For the files (pmore than 10000) I did it mainly by hand but sometimes this went wrong... in particular when the previous sage characters we used as representatives for the galois orbits either were changed (the default ordering in sage changed) or they were no longer representatives for Conrey orbits 8n which case again I tried to change them by hand. And this of course also probably failed some times...

3) Remaining problems from when I have tried automatically to fix the above problems. Since these computations are very slow I have tried to use parallel computations as much as possible but that had the effect that a lot of errors (both bugs and mongodb write errors) were simply ignored.

@sehlen: I find it strange 5hat the computing routines doesn't work for you. I managed to manually fix the few cases I looked at by using that (and go back and redo some of the primitive data). I will have a look on Monday at all this.... If I had just known a few weeks earlier I would have had time to fix this....

Fredrik

On Sat, 7 May 2016 21:44 jvoight, notifications@github.com wrote:

It's definitely "less bad" to hide wrong data than to display it, so if we are confident with Gamma_0, then I vote that we hide just Gamma_1 for Tuesday until the data can be verified.

It's extremely important to get the MF to stand up straight in LMFDB. Even for new things: I can't compute base change HMFs, we can't match genus 2 curves of GL_2-type, etc., until classical MFs is stable and correct. I'd strongly encourage some subset of people to focus 100% on this next week.

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217667724

jwbober commented 8 years ago

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/29/4/1/a/ looks like the coefficients might be correct, but the embeddings are completely off.

fredstro commented 8 years ago

Of course, I forgot to mention that there are also errors that are there because I recomputed the form but it didn't update everything and in particular there were cases where the coefficients were replaced but not the embeddings. (and possibly also not parts of the q - expansions -- which happens to be stored both in the mongo record and in the gridfs -- since they may go over the 16mb limit...)

On Sat, 7 May 2016 22:12 Jonathan Bober, notifications@github.com wrote:

http://www.lmfdb.org/ModularForm/GL2/Q/holomorphic/29/4/1/a/ looks like the coefficients might be correct, but the embeddings are completely off.

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217669162

jwbober commented 8 years ago

Trivial character is not so bad. There seem to be a small enough number of errors that I think I know what is wrong in each case. (I've done the comparison on weights 2 though 12 and level < 100, and weights 2 through 4 and level < 400. Above level 100 things get better for trivial character at least.)

For the forms

29.4.1.a 31.4.1.a 33.4.1.d 34.4.1.c 35.4.1.b 38.4.1.b 39.4.1.b 44.4.1.b

the embeddings are completely wrong. (Probably they start with a(101), as Fredrik suggests.) Perhaps the algebraic coefficients are correct. Anyway, those are probably small enough that the whole space can be recomputed quickly.

For the forms

71.12.1.b 79.12.1.a 79.12.1.b 83.10.1.b 89.12.1.a 89.12.1.b 97.12.1.a 97.12.1.b 97.8.1.b

I think I run into issues because the embeddings are not accurate enough. So probably the forms are basically correct, but the embeddings can be way off when only computed with 53 bits of working precision.

My comparisons are not completely reliable right now, but are pretty good. Basically, for level < 100 and weight 2 through 12, and level < 400 or so and weight 2 through 4, and every character, I've (numerically) computed embeddings of every modular form, but I don't have algebraic information (e.g. Galois orbits). (In some cases, when I have enough precision, I can identify things as exact algebraic numbers, and get the algebraic information, but it is going to be impossible to always do this, and I haven't yet tried to do it systematically.)

Anyway, I've used the embeddings that I grabbed from the database to try to match embeddings that I've computed. For a form in a given space, I use the first 30 coefficients (or just a(p) for p < 30) to select the closest form out of the forms I've computed in that space, using some sort of L2 distance (first normalizing coefficients so that they have absolute value < 1, to deal with some precision issues). The cases above are the ones where this distance is > .5 for at least one of the embeddings.

I haven't checked yet that everything that should be in the database is there, but I have at least checked that for the forms that do match one of my forms, none of my forms is matched twice.

My checks will not see any problems if there happen to be cases where the algebraic coefficients are wrong but the embeddings are correct.

AndrewVSutherland commented 8 years ago

Some possibly useful stats on the 2450 spaces currently in modularforms2.webmodformspace that have trivial character. Of these, there is a complete set of (not necessarily correct) newform records in modularforms2.webnewforms matching the list of hecke_orbit_labels for all but 227 spaces. Among these 227 spaces, there are no hecke_orbit records at all for 222, in which case the user not be able to navigate to them (other than typing in the URL directly). The remaining 25 have some but not all of the newforms they should, which will mean the user can navigate to a page that will show some missing. I might suggest that for these 25 we either fill in the missing ones are delete the ones that are there.

Here is a list of the 25: 37.12.1 41.10.1 41.12.1 50.4.1 5.34.1 5.36.1 13.32.1 17.20.1 19.18.1 47.8.1 65.12.1 71.6.1 73.10.1 79.6.1 87.12.1 89.8.1 89.12.1 91.12.1 97.8.1 97.12.1 49.8.1 49.12.1 85.4.1 2.12.1 3.86.1

sehlen commented 8 years ago

I started to work on this list but I am a bit confused because the majority seem in fact to be complete. In fact, I started recording those that are ok and then it turns out that I ended up with this list: 37.12.1 41.10.1 50.4.1 5.36.1 13.32.1 17.20.1 19.18.1 65.12.1 71.6.1 73.10.1 79.6.1 87.12.1 89.8.1 91.12.1 97.8.1 2.12.1 (there are in fact no newforms)

Most importantly, I managed to fix the remaining ones, feel free to check: 41.12.1 5.34.1 47.8.1 89.12.1 97.12.1 49.8.1 49.12.1 85.4.1 3.86.1

sehlen commented 8 years ago

@jwbober The list you gave for trivial character should be fixed now, please rerun your checks. I think there was no change for the ones of higher level so maybe we should increase the precision. I guess we should open an issue and come up with a good formula which precision would be sufficient depending on the space. But the forms of lower level should not show up in your list anymore, I think. The embeddings were wrong and it was as Fredrik said, I think.

sehlen commented 8 years ago

I just checked what sage gives when called directly and indeed increasing the precision for the higher level/weight cases gives substantially different results. I guess this has not been taken account of in the computation of the embeddings as of now. This should not be too hard to fix.

AndrewVSutherland commented 8 years ago

I think our results differ because I was not filtering by version, but looking more closely I see that I should presumably only be looking at records in webmodformspace that have 'version' set to 1.3, since all the records in webnewforms have 'version' set to 1.3. I will update my script to account for this and rerun (which will then also reflect your recent updates).

Part of the problem here is that there is no information listed in the github inventory for modular forms (or if there is, I can't easily find it). See https://github.com/LMFDB/lmfdb-inventory/issues/13 (which I just updated). This is obviously not the top priority at the moment, but perhaps it is something that could be addressed during the workshop next week.

We really do need to have documentation that explains all the data in the mongo db that is actually used in the production system (the modularforms2 database is particularly confusing because there are so many different collections and different versions of records in each collections).

On 2016-05-08 00:09, Stephan Ehlen wrote:

I started to work on this list but I am a bit confused because the majority seem in fact to be complete. In fact, I started recording those that are ok and then it turns out that I ended up with this list: 37.12.1 41.10.1 50.4.1 5.36.1 13.32.1 17.20.1 19.18.1 65.12.1 71.6.1 73.10.1 79.6.1 87.12.1 89.8.1 91.12.1 97.8.1 2.12.1 (there are in fact no newforms)

Most importantly, I managed to fix the remaining ones, feel free to check: 41.12.1 5.34.1 47.8.1 89.12.1 97.12.1 49.8.1 49.12.1 85.4.1 3.86.1


You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217690268

AndrewVSutherland commented 8 years ago

OK, I reran the script and can confirm that there are now no partially complete spaces with trivial character. There are a bunch that have no Hecke orbit data, which is fine since no link to the space is displayed in this case. The script is lmfdb/modular_forms/elliptic_modular_forms/emf_db_stats.py, which I added in pull request #1235 (in case you want to make any corrections or additions). It also checks that the Hecke orbits are labeled consistently, and when present, that the dimensions sum correctly (this was true in every case where there were Hecke orbits present).

Below is the output of the script, which lists the spaces with missing data. I note that in every case the list of Hecke orbit labels has length equal to the dimension which I assume is just a temporary place holder (surely they do not all have dimension 1?!). This isn't visible to the user, so I don't see it as an immediate problem.

No Hecke orbit data for space 7.32.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 7.34.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.36.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.22.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 7.24.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 7.26.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 7.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 7.30.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 17.24.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 17.26.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 17.28.1 of dimension 36 with 36 Hecke orbits No Hecke orbit data for space 17.32.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 17.52.1 of dimension 68 with 68 Hecke orbits No Hecke orbit data for space 18.32.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 19.38.1 of dimension 56 with 56 Hecke orbits No Hecke orbit data for space 21.20.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 24.14.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 24.16.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 24.20.1 of dimension 9 with 9 Hecke orbits No Hecke orbit data for space 24.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 25.14.1 of dimension 19 with 19 Hecke orbits No Hecke orbit data for space 25.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 25.22.1 of dimension 32 with 32 Hecke orbits No Hecke orbit data for space 25.32.1 of dimension 47 with 47 Hecke orbits No Hecke orbit data for space 26.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 26.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 26.32.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 28.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 28.26.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 29.14.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 29.16.1 of dimension 35 with 35 Hecke orbits No Hecke orbit data for space 29.18.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 29.24.1 of dimension 53 with 53 Hecke orbits No Hecke orbit data for space 29.26.1 of dimension 59 with 59 Hecke orbits No Hecke orbit data for space 30.14.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 30.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 31.14.1 of dimension 33 with 33 Hecke orbits No Hecke orbit data for space 32.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 32.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 32.22.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 33.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 33.16.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 33.22.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 33.28.1 of dimension 46 with 46 Hecke orbits No Hecke orbit data for space 34.14.1 of dimension 16 with 16 Hecke orbits No Hecke orbit data for space 34.16.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 34.18.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 34.30.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 35.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 35.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 35.26.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 36.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 36.16.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 37.14.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 37.16.1 of dimension 45 with 45 Hecke orbits No Hecke orbit data for space 39.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 39.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 40.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 40.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 41.14.1 of dimension 44 with 44 Hecke orbits No Hecke orbit data for space 41.16.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 42.14.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 42.16.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 44.14.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 44.16.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 45.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 45.16.1 of dimension 25 with 25 Hecke orbits No Hecke orbit data for space 48.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 48.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 50.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 50.16.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 51.14.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 51.16.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 52.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 52.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 52.8.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 53.14.1 of dimension 57 with 57 Hecke orbits No Hecke orbit data for space 55.14.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 56.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 56.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 58.14.1 of dimension 29 with 29 Hecke orbits No Hecke orbit data for space 60.14.1 of dimension 8 with 8 Hecke orbits No Hecke orbit data for space 60.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 61.14.1 of dimension 65 with 65 Hecke orbits No Hecke orbit data for space 73.14.1 of dimension 78 with 78 Hecke orbits No Hecke orbit data for space 87.10.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 89.14.1 of dimension 96 with 96 Hecke orbits No Hecke orbit data for space 97.14.1 of dimension 104 with 104 Hecke orbits

fredstro commented 8 years ago

I agree that the database modularforms2 is very confusing with so many collections. Many of them have only been used temporarily for error checking etc.

I think it would be good to create a new database where only the collections used for the objects displayed by lmfdb are present. The " computation database" doesn't even need to be on the same mongo server and it might be better for the performance to set up a separate mongo server for that.

On Sun, 8 May 2016 12:53 AndrewVSutherland, notifications@github.com wrote:

OK, I reran the script and can confirm that there are now no partially complete spaces with trivial character. There are a bunch that have no Hecke orbit data, which is fine since no link to the space is displayed in this case. The script is lmfdb/modular_forms/elliptic_modular_forms/emf_db_stats.py, which I added in pull request #1235 https://github.com/LMFDB/lmfdb/pull/1235 (in case you want to make any corrections or additions). It also checks that the Hecke orbits are labeled consistently, and when present, that the dimensions sum correctly (this was true in every case).

Below is the output of the script, which lists the spaces with missing data. I note that in every case the list of Hecke orbit labels has length equal to the dimension which I assume is just a temporary place holder (surely they do not all have dimension 1?!). This isn't visible to the user, so I don't see it as a problem.

No Hecke orbit data for space 53.14.1 of dimension 57 with 57 Hecke orbits No Hecke orbit data for space 17.24.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 41.16.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 7.34.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.30.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 28.26.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 7.36.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.22.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 7.24.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 45.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 24.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 30.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 34.30.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 24.20.1 of dimension 9 with 9 Hecke orbits No Hecke orbit data for space 24.16.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 36.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 87.10.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 34.14.1 of dimension 16 with 16 Hecke orbits No Hecke orbit data for space 7.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 25.32.1 of dimension 47 with 47 Hecke orbits No Hecke orbit data for space 25.14.1 of dimension 19 with 19 Hecke orbits No Hecke orbit data for space 50.16.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 25.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 28.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 52.8.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 37.16.1 of dimension 45 with 45 Hecke orbits No Hecke orbit data for space 37.14.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 7.32.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 48.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 29.16.1 of dimension 35 with 35 Hecke orbits No Hecke orbit data for space 42.16.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 42.14.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 44.16.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 25.22.1 of dimension 32 with 32 Hecke orbits No Hecke orbit data for space 36.16.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 40.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 51.14.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 30.14.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 45.16.1 of dimension 25 with 25 Hecke orbits No Hecke orbit data for space 35.26.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 19.38.1 of dimension 56 with 56 Hecke orbits No Hecke orbit data for space 29.18.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 29.24.1 of dimension 53 with 53 Hecke orbits No Hecke orbit data for space 29.26.1 of dimension 59 with 59 Hecke orbits No Hecke orbit data for space 39.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 73.14.1 of dimension 78 with 78 Hecke orbits No Hecke orbit data for space 50.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 18.32.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 51.16.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 56.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 89.14.1 of dimension 96 with 96 Hecke orbits No Hecke orbit data for space 60.14.1 of dimension 8 with 8 Hecke orbits No Hecke orbit data for space 32.22.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 56.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 41.14.1 of dimension 44 with 44 Hecke orbits No Hecke orbit data for space 17.32.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 34.18.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 34.16.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 52.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 31.14.1 of dimension 33 with 33 Hecke orbits No Hecke orbit data for space 35.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 35.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 24.14.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 17.26.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 32.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 7.26.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 26.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 33.28.1 of dimension 46 with 46 Hecke orbits No Hecke orbit data for space 21.20.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 17.28.1 of dimension 36 with 36 Hecke orbits No Hecke orbit data for space 32.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 33.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 60.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 26.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 39.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 26.32.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 44.14.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 33.22.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 29.14.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 52.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 55.14.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 33.16.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 58.14.1 of dimension 29 with 29 Hecke orbits No Hecke orbit data for space 97.14.1 of dimension 104 with 104 Hecke orbits No Hecke orbit data for space 40.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 48.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 17.52.1 of dimension 68 with 68 Hecke orbits No Hecke orbit data for space 61.14.1 of dimension 65 with 65 Hecke orbits

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217711454

sehlen commented 8 years ago

Separating the databases and also cleaning up the database for the website is exactly what I wanted to put on my todo list for this week. And that will come along with some more query tools and documentation. It would be great if you could help from the UK, @fredstro.

On Sun, May 8, 2016, 09:13 Fredrik Strömberg notifications@github.com wrote:

I agree that the database modularforms2 is very confusing with so many collections. Many of them have only been used temporarily for error checking etc.

I think it would be good to create a new database where only the collections used for the objects displayed by lmfdb are present. The " computation database" doesn't even need to be on the same mongo server and it might be better for the performance to set up a separate mongo server for that.

On Sun, 8 May 2016 12:53 AndrewVSutherland, notifications@github.com wrote:

OK, I reran the script and can confirm that there are now no partially complete spaces with trivial character. There are a bunch that have no Hecke orbit data, which is fine since no link to the space is displayed in this case. The script is lmfdb/modular_forms/elliptic_modular_forms/emf_db_stats.py, which I added in pull request #1235 https://github.com/LMFDB/lmfdb/pull/1235 (in case you want to make any corrections or additions). It also checks that the Hecke orbits are labeled consistently, and when present, that the dimensions sum correctly (this was true in every case).

Below is the output of the script, which lists the spaces with missing data. I note that in every case the list of Hecke orbit labels has length equal to the dimension which I assume is just a temporary place holder (surely they do not all have dimension 1?!). This isn't visible to the user, so I don't see it as a problem.

No Hecke orbit data for space 53.14.1 of dimension 57 with 57 Hecke orbits No Hecke orbit data for space 17.24.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 41.16.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 7.34.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.30.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 28.26.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 7.36.1 of dimension 17 with 17 Hecke orbits No Hecke orbit data for space 7.22.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 7.24.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 45.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 24.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 30.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 34.30.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 24.20.1 of dimension 9 with 9 Hecke orbits No Hecke orbit data for space 24.16.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 36.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 87.10.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 34.14.1 of dimension 16 with 16 Hecke orbits No Hecke orbit data for space 7.28.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 25.32.1 of dimension 47 with 47 Hecke orbits No Hecke orbit data for space 25.14.1 of dimension 19 with 19 Hecke orbits No Hecke orbit data for space 50.16.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 25.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 28.14.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 52.8.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 37.16.1 of dimension 45 with 45 Hecke orbits No Hecke orbit data for space 37.14.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 7.32.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 48.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 29.16.1 of dimension 35 with 35 Hecke orbits No Hecke orbit data for space 42.16.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 42.14.1 of dimension 14 with 14 Hecke orbits No Hecke orbit data for space 44.16.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 25.22.1 of dimension 32 with 32 Hecke orbits No Hecke orbit data for space 36.16.1 of dimension 6 with 6 Hecke orbits No Hecke orbit data for space 40.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 51.14.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 30.14.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 45.16.1 of dimension 25 with 25 Hecke orbits No Hecke orbit data for space 35.26.1 of dimension 50 with 50 Hecke orbits No Hecke orbit data for space 19.38.1 of dimension 56 with 56 Hecke orbits No Hecke orbit data for space 29.18.1 of dimension 39 with 39 Hecke orbits No Hecke orbit data for space 29.24.1 of dimension 53 with 53 Hecke orbits No Hecke orbit data for space 29.26.1 of dimension 59 with 59 Hecke orbits No Hecke orbit data for space 39.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 73.14.1 of dimension 78 with 78 Hecke orbits No Hecke orbit data for space 50.14.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 18.32.1 of dimension 12 with 12 Hecke orbits No Hecke orbit data for space 51.16.1 of dimension 40 with 40 Hecke orbits No Hecke orbit data for space 56.16.1 of dimension 22 with 22 Hecke orbits No Hecke orbit data for space 89.14.1 of dimension 96 with 96 Hecke orbits No Hecke orbit data for space 60.14.1 of dimension 8 with 8 Hecke orbits No Hecke orbit data for space 32.22.1 of dimension 21 with 21 Hecke orbits No Hecke orbit data for space 56.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 41.14.1 of dimension 44 with 44 Hecke orbits No Hecke orbit data for space 17.32.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 34.18.1 of dimension 24 with 24 Hecke orbits No Hecke orbit data for space 34.16.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 52.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 31.14.1 of dimension 33 with 33 Hecke orbits No Hecke orbit data for space 35.16.1 of dimension 30 with 30 Hecke orbits No Hecke orbit data for space 35.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 24.14.1 of dimension 7 with 7 Hecke orbits No Hecke orbit data for space 17.26.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 32.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 7.26.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 26.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 33.28.1 of dimension 46 with 46 Hecke orbits No Hecke orbit data for space 21.20.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 17.28.1 of dimension 36 with 36 Hecke orbits No Hecke orbit data for space 32.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 33.14.1 of dimension 20 with 20 Hecke orbits No Hecke orbit data for space 60.16.1 of dimension 10 with 10 Hecke orbits No Hecke orbit data for space 26.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 39.14.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 26.32.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 44.14.1 of dimension 11 with 11 Hecke orbits No Hecke orbit data for space 33.22.1 of dimension 34 with 34 Hecke orbits No Hecke orbit data for space 29.14.1 of dimension 31 with 31 Hecke orbits No Hecke orbit data for space 52.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 55.14.1 of dimension 42 with 42 Hecke orbits No Hecke orbit data for space 33.16.1 of dimension 26 with 26 Hecke orbits No Hecke orbit data for space 58.14.1 of dimension 29 with 29 Hecke orbits No Hecke orbit data for space 97.14.1 of dimension 104 with 104 Hecke orbits No Hecke orbit data for space 40.16.1 of dimension 15 with 15 Hecke orbits No Hecke orbit data for space 48.14.1 of dimension 13 with 13 Hecke orbits No Hecke orbit data for space 17.52.1 of dimension 68 with 68 Hecke orbits No Hecke orbit data for space 61.14.1 of dimension 65 with 65 Hecke orbits

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217711454

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/LMFDB/lmfdb/issues/1223#issuecomment-217717945

AndrewVSutherland commented 8 years ago

One thing I might suggest (not right now, but down the road) is that you distinguish versions at the collection or even database level, not at the record level. Having to filter by version (and including the version attribute in all your keys) slows things down and, more seriously, it invites mistakes. Suppose someone accesses the collection using the find_one() method (specifying a label they think should be a unique key) and does not specify the version attribute -- their code might well see a mixture of different versions that are just similar enough for their code to work. This could produce very subtle bugs.

More generally, we should all bear in mind that the data we store in the LMFDB mongo db is public. Anyone (not just LMFDB developers) can access the data on a read-only basis through the LMFDB API (see http://lmfdb.warwick.ac.uk/api/). In the future there may very well be applications or users (e.g. from Sage math cloud) pulling data from the LMFDB mongo database that do not necessarily use any of our code to access it (they might not even be coding in python).

As individual developers we may find it convenient to implement a python class that manages access data associated to a particular object and have our code view the associated mongo db data as "private" to that class, but there is nothing that forces others to do the same (not even with the LMFDB development community), nor do we want there to be. Any data augmentation or access control that is implemented in such a class as a layer above the data may be completely invisible to others, and we should all keep this in mind (think of your class as a "glass box" not a black box).

AndrewVSutherland commented 8 years ago

I think it makes sense to merge this issue with (a renamed) #1248, since at this point they are more or less about the same thing and all the recent discussion is on #1248

AndrewVSutherland commented 8 years ago

Issue merged wiht #1248