Closed ericanaughton closed 8 years ago
@bigtiger should we use TravisCI or CircleCI?
PR https://github.com/adorableio/LMHT/pull/36 ready to reviews (adds linter)
PR https://github.com/adorableio/LMHT/pull/35 appeases the linter errors (rules are set at a basic level for now). This will not be ready to merge until the previous PR is merged and a PR with TravisCI is merged.
linter and travis ci is merged, fixes are ready for review https://github.com/adorableio/LMHT/pull/35
merged
Suggested by @whazzmaster: Use eslint or similar; hook it up to travis or circleci so we can get style feedback before commit/PR merge.
In order to maintain standards and consistency As a developer working on LMHT I want to have a linter give me feedback before I get my PR reviewed.
Acceptance Criteria
npm install
should install everything needed to be able to run the linternpm test
should run the linter with the needed argumentsnode_modules
directory should not be commit to github