search

LMHT / LMHT.github.io

https://lmht.github.io
15 stars 8 forks source link

Fix Contribute Ribbon When Screen Size Reduced - Part 2 #185

Closed kathyoleary closed 8 years ago

kathyoleary commented 8 years ago

In order to have access to all elements of the LMHT screen, As an LMHT user, I want to be able to minimize the screen and still have access to the search bar.

Acceptance Criteria: (Fix in two parts - this is Part 2) Total Criteria: Fix Contribute ribbon so it does not cover over search box when screen size is reduced. Criteria for Part 1: Have Contribute Ribbon disappear when screen size reduces enough that it covers other divs. Criteria for Part 2: Once current Contribute Ribbon disappears on screen reduction, have a different smaller one added on the bar that is part of the bar and does not cover it.

Given any LMHT user, I want to minimize the screen And still be able to access the search bar.

kathyoleary commented 8 years ago

WIP: https://github.com/adorableio/LMHT/pull/64 Still working on it, but here's where the PR's are going.

kathyoleary commented 8 years ago

FYI Note: may need to do this as a fix, need to decide if we want to....we have the screen reduction set to get rid of the contribute ribbon and the LMHT logo and put the on the ribbon above the sticky nav....but the changed logo and contribute ribbon only show when the screen is small enough to activate the innermost sticky nav and bring the wider blue ribbon with it. So if you have the screen open vertically long enough that it hasn't activated the sticky nav to the top of the page, then there is no contribute ribbon, and no separate LMHT logo. But at that point we have the header which has the LMHT logo and whatnot....just no GitHub contribute ribbon.

So do we fix?

kathyoleary commented 8 years ago

https://github.com/adorableio/LMHT/pull/64 sent out for review

kathyoleary commented 8 years ago

Did the change with the the contribute ribbon and the LMHT logo. Have an outstanding issue to fix with next Sprint as part of the search bar is getting overlaid and you can't view the down arrow at the end. It's in https://github.com/LMHT/LMHT.github.io/issues/198 to fix it. It happens at all times, not just on screen reduction with the ribbon having to convert to the double row'ed ribbon. It also happens if you're at the top of the screen on the regular single row search bar/ribbon. (see images in the PR)