search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.18k stars 1.01k forks source link

The send knobs don't remember their links #1147

Closed rawthought closed 10 years ago

rawthought commented 10 years ago

Hi,

I have noticed that the "send knobs" in the mixer panel aren't remembering their links when we quit the track and recall it with lmms.

I have linked some send knobs with peak controllers or effect curves and I have to relink them each time I reload the track.

Sorry for my english, I hope I am understandable.

tresf commented 10 years ago

Which build/branch/os are you working from so that we can reproduce?

-Tres

mikobuntu commented 10 years ago

I can also confirm this bug running stable-1.1 linux ubuntu-12.04 ( 32bit) built from git today. Also note that it does not even take a song close&&open to cause this. For example if i have a peak controller on an FX channel and a trigger e.g a kicker going to this channel, i can link a send channel to this controller and it does exactly what it is supposed to... but if i click "off" and then "on" for the send that is linked to the peak controller then the connection is lost ... this is maybe not easy to explain, if anyone needs me to show this on my youtube channel then feel free to ask thanks Mikobuntu ;)

Date: Tue, 9 Sep 2014 12:33:56 -0700 From: notifications@github.com To: lmms@noreply.github.com Subject: Re: [lmms] The send knobs don't remember their links (#1147)

Which build/branch/os are you working from so that we can reproduce?

-Tres

— Reply to this email directly or view it on GitHub. =

diizy commented 10 years ago

On 09/09/2014 10:52 PM, Mikobuntu wrote:

I can also confirm this bug running stable-1.1 linux ubuntu-12.04 ( 32bit) built from git today. Also note that it does not even take a song close&&open to cause this. For example if i have a peak controller on an FX channel and a trigger e.g a kicker going to this channel, i can link a send channel to this controller and it does exactly what it is supposed to... but if i click "off" and then "on" for the send that is linked to the peak controller then the connection is lost ... this is maybe not easy to explain, if anyone needs me to show this on my youtube channel then feel free to ask thanks Mikobuntu ;)

The solving of this problem is going to require some more reworking in the FxMixer...

Also, there's a very high probability that the fix is going to break compatibility with all current projects made with 1.1 or later. So, you know, prepare for that.

mikobuntu commented 10 years ago

Yes i have been following the development of LMMS very closely and I know not to depend on it fully for my audio work. maybe it should be stressed in the release notes of stable-1.1 that LMMS is under heavy construction at the moment and to backup often ( incase of crashes etc ) and to remember that LMMS is still young in development, Compare apps like Ardour and their 3.0 release , especially the new midi tracks I have found it to crash constantly and like many other apps out there new addons usually break some form of compat, take Renoise and their 3.0 release, the whole concept has changed and usually you will need to run an older version if you created a song in it, so I think people will generally understand this, all that aside great job @vesa and others for all the hard work .....

thanks Mikobuntu ;)

The solving of this problem is going to require some more reworking in

the FxMixer...

Also, there's a very high probability that the fix is going to break

compatibility with all current projects made with 1.1 or later. So, you

know, prepare for that.

— Reply to this email directly or view it on GitHub. =

tresf commented 10 years ago

The solving of this problem is going to require some more reworking in the FxMixer...
Also, there's a very high probability that the fix is going to break compatibility with all current projects made with 1.1 or later. So, you know, prepare for that.

Well, now's the time, before 1.1. is released, right?

-Tres

diizy commented 10 years ago

On 09/09/2014 11:48 PM, Tres Finocchiaro wrote:

The solving of this problem is going to require some more reworking in
the FxMixer...

Also, there's a very high probability that the fix is going to break
compatibility with all current projects made with 1.1 or later.
So, you
know, prepare for that.

Well, now's the time, before 1.1. is released, right?

Sure, working on it now.

Note also, however: enabling/disabling sends is still going to destroy connections. The same way as deleting a channel and then creating a new one will destroy connections to the channel's volume fader. This is simply unavoidable.

diizy commented 10 years ago

On the upside... I /might /be able to preserve compat after all, no promises though.

mikobuntu commented 10 years ago

tested and it works for me on both my old test song and a newly created one :) As you said earlier tho you don't think that the toggle off/on of the send switch itself can remember settings, i understand this and it's no real show stopper, maybe further down the line this can be addressed, but the initial bug is fixed

thanks Mikobuntu ;)

Closed #1147 via #1149.

— Reply to this email directly or view it on GitHub. =

diizy commented 10 years ago

On 09/10/2014 12:56 AM, Mikobuntu wrote:

As you said earlier tho you don't think that the toggle off/on of the send switch itself can remember settings, i understand this and it's no real show stopper, maybe further down the line this can be addressed

No it can't, not without completely redesigning how connections to models work. Like I said, think of enabling a send not as "switching on" something, but rather as creating a new "route" object between the two channels, because that's actually what happens under the hood, it's just been abstracted by the UI. Naturally, when you create a new object, it comes with a clean slate, no connections or anything - it's analoguous with destroying and re-creating a fx channel.

tresf commented 10 years ago

@diizy, would this warrant an RC6?

rawthought commented 10 years ago

Yeah ! It seems to work well for me too ! :) thanks for this very quick fix ! (and sorry for my inaccurate first post, my OS is Debian Wheezy 64 bit)

mikobuntu commented 10 years ago

just my 2 cents but i don't believe this ( the part about the on/off switch that @diizy explained to us ) should alone hold back the 1.1 release, but i do believe a more serious bug i.e this one https://github.com/LMMS/lmms/issues/1048 could perhaps delay the release. I as others have noticed that a CPU spike will cause a complete audio dropout, where only a restart will fix it until the next cpu spike.

thanks Mikobuntu ;)

@diizy, would this warrant an RC6?

— Reply to this email directly or view it on GitHub. =

mikobuntu commented 10 years ago

see my video related to #1048 here http://youtu.be/n4La_ptvsacI will post this as a reply to the github issue tracker now too, just replying in the mean time here as an update to my last reply....

thanks Mikobuntu ;)

From: chrissy.mc.1@hotmail.co.uk To: reply@reply.github.com Subject: RE: [lmms] The send knobs don't remember their links (#1147) Date: Tue, 9 Sep 2014 22:29:22 +0000

just my 2 cents but i don't believe this ( the part about the on/off switch that @diizy explained to us ) should alone hold back the 1.1 release, but i do believe a more serious bug i.e this one https://github.com/LMMS/lmms/issues/1048 could perhaps delay the release. I as others have noticed that a CPU spike will cause a complete audio dropout, where only a restart will fix it until the next cpu spike.

thanks Mikobuntu ;)

@diizy, would this warrant an RC6?

— Reply to this email directly or view it on GitHub. =

tresf commented 10 years ago

@mikobuntu, unfa says he's been fighting that bug for years. Doesn't that suggest it is not new or has the issue worsened with 1.1?

diizy commented 10 years ago

On 09/10/2014 01:16 AM, Tres Finocchiaro wrote:

@diizy https://github.com/diizy, would this warrant an RC6?

Eh... probably not, not that big a change.