Percussive notes ignored and seem to produce empty clips in Song Editor

[unfa]

I've noticed that percussive notes (only Note-ON) are not treated the same way as regular notes (Note-ON + Note-OFF). Specifically - they seem to ignored when drawing clips in Song Editor.

As we know, empty clips are gray. But clips with percussive notes only are also drawn as gray - meanng empty - and that's misleading!

To reproduce:

1. Run LMMS;
2. Create an empty instrument clip in the Song Editor (left click on a bar);
3. Zoom in until you see the rhytmic editor;
4. Insert some notes with LMB or mousewheel-up;
5. Zoom out until the rhythmic editor dissapears;
6. It's gray.

If you rightclick on the clip and select "Add notes" you can create two-bar-long empty-looking clip. Funny, isn't it?

[tresf]

I don't believe the Song Editor was ever intended to be used as a step sequencer (or if it is, is very evident that it needs improvement). This goes to general usability and consistancy improvements with the Song Editor and BB Editor. Valid, but I'm pretty sure there's other bugs floating around that could be a duplicate of this (or vice versa).

[diizy]

On 09/19/2014 02:37 AM, Tres Finocchiaro wrote:

I don't believe the Song Editor was ever intended to be used as a step sequencer (or if it is, is very evident that it needs improvement). This goes to general usability and consistancy improvements with the Song Editor and BB Editor. Valid, but I'm pretty sure there's other bugs floating around that could be a duplicate of this (or vice versa).

Yeah... the whole "beat pattern in song editor" is a neat feature, but... it's just that, a neat feature, that pretty much no one ever uses. It's just inconvenient, if you want to add short beats to the song editor, it's much easier to just use regular bb-tracks...

I think issues like this will be solved when we do the big bb-editor rehaul. I'm not sure when this will be, but it will involve rewriting the way beat patterns work. Probably also we can separate beat patterns into their own class, which could solve a ton of issues.

[unfa]

I'm not saying that Song Editor should or shouldn't have the Step Sequencer functionality.

I only wanted to point the erronous graphics. I sometimes use these percusive notes for rarely used one-shot sound effects.

[diizy]

On 09/19/2014 02:36 PM, unfa wrote:

I'm not saying that Song Editor should or shouldn't have the Step Sequencer functionality.

I only wanted to point the erronous graphics. I sometimes use these percusive notes for rarely used one-shot sound effects.

It's not erroneous really. This is related to the whole beat pattern thing I talked about earlier. We currently use the same pattern class for both beat patterns and melody patterns. We differentiate them by their content: any pattern that only has beat notes is considered a beat pattern. So when you have a beat pattern in the song editor, it shows up as a beat pattern - if you zoom in enough, you'll see the beat steps in the pattern, but zoomed out it just looks like an empty grey pattern.

So like I said, this is related to the way we handle beat patterns, and thus it'll probably get fixed when we revise how beat patterns work. Probably a good idea would be to separate beat patterns as their own class instead of using the pattern class for both types of patterns. Maybe subclass both pattern types into subclasses of "pattern". This way, when a melody pattern has only beat notes, we can show the pattern as we show regular melody patterns. There's just the question of how we handle converting beat patterns into melody patterns (eg. when a user wants to use melody patterns in the bb-editor).

[Rossmaxx]

Step notes in song editor has been removed. Close?

[tresf]

Step notes in song editor has been removed. Close?

Sure, was there a particular PR or commit that can be referenced?

[Rossmaxx]

5988