search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.02k stars 998 forks source link

Remove all "NOT FOUND!" plugins with one click #1533

Open unfa opened 9 years ago

unfa commented 9 years ago

When I load a project and I have any "not found" plugins I frequently just search throught the whole project to delete the "not found" plugins. This way the project is WYSIWYG - no surprises in the future.

tresf commented 9 years ago

Hmm... this should be the exception... do you encounter this often? I'm not sure where we'd even put such an option... :)

-Tres

badosu commented 9 years ago

Perhaps we could inform which tracks are using the plugins that are missing, that would be a mid-term solution.

tresf commented 9 years ago

Fixed. :)

Perhaps we could inform which tracks or FX channels are using the plugins that are missing, that would be a mid-term solution.

badosu commented 9 years ago

@tresf Sorry, I did not understand your last post, what is the correction?

tresf commented 9 years ago

what is the correction?

or FX channels :)

tresf commented 9 years ago

what is the correction?

Plugins (such as LADSPA or VST Effect Plugins) can be attributed to either an FX channel or an instrument currently. I just quoted your post and put in the details about the FX channel. :)

badosu commented 9 years ago

Yeah, I got it.

Track or FX channel : ).

unfa commented 9 years ago

Having some indication where to look for those would be nice, however it doesn't really fix the problem - as still the user has to the dirty (non-productive, time-consuming) job, while the program could do it for him quickly (I mean of course finding and removing all missing plugins).

badosu commented 9 years ago

@unfa Yeah, I agree, that's why this would be just a mitigation for the problem not an actual fix.

Perhaps one idea would be to add a button besides the Ok button on the errors message box? What would be it's label?

musikBear commented 9 years ago

similar to #733 in context of 'Dummy' insertions -Those 'Dummies' still anomineus, and difficult to find. imo -the remove-cmd couls be an item in the Edit-menu

ghost commented 9 years ago

I can't figure out how it lists the plugins. Is there anyway I could take a variable which stores the file names like lets say "file" and do something like QFileInfo (check(path)); if (!check.exists){ //code needed to remove it from list }? If so what variable is it? What do I need to do to remove it from the list?

tresf commented 9 years ago

The software already checks for existance. I'd say if instance is DummyPlugin, remove. :)

badosu commented 9 years ago

@unfa @tresf Could you help me define the location for this action?

Would it be on the main Edit menu?

tresf commented 9 years ago

@badosu I would vote the Tools menu.

What would be a nice enhancement to that is the possibility of also adding it to any ERROR plugin directly under the "Remove plugin" menu item, perhaps "Remove all missing plugins".

-Tres

luzpaz commented 1 year ago

Is this ticket still relevant ?

tresf commented 1 year ago

Should be, yeah. It's missing steps to reproduce though, which makes it hard to understand.

From my understanding:

  1. Download a VST effect
  2. Add a VST effect to an instrument or FX channel
  3. Save and close the project
  4. Delete this VST from the computer
  5. Open the project

This seems like and edge-case but on Linux distros, we'll scan and add certain effects automatically (e.g. LADSPA effects) and all platforms can do the same for VST effects, so when sharing project with others, this can happen quite a bit. Stock effects are much less likely to have this happen since we try to bundle them with each release.

@unfa 's -- valid -- argument is, hunting these down can be cumbersome and time consuming. One may wish to automatically remove these, but that can regress the project file, so the user should have the choice.

musikBear commented 1 year ago

I would prefer that a kind of 'dummy' is preserved when LMMS does not find a plugin. The purpose should be to keep all settings that was in the orr. saved plugin, so a resolve could be achieved if the user re-find the missing plugin. If the plugin and its setting simply is removed, then it is cumbersome to recreate the orr. project, perhaps even impossible. A low-tech way to achieve this could be just creating a doublet project where nothing is changed and then load a version where the plugin is removed, but keeping name and path as information to the user, that current loaded project is flawed and missing parts. The user could then re-install the missing parts/ plugins and then be able to reopen the doublet-project in full

tresf commented 1 year ago

so a resolve could be achieved if the user re-find the missing plugin [...] The user could then re-install the missing parts/ plugins and then be able to reopen the doublet-project in full

Agreed.