Closed zonkmachine closed 10 years ago
i can confirm i do not get a sound preview either when using the random function, mutate, or actually on changing to any of the waveforms or generators as the original sfxr plugin does. it is certainly no show stopper tho as this is an amazing plugin, capable of some really great sounds
thanks Mikobuntu
this is an amazing plugin, capable of some really great sounds
It totally rocks... ;-)
yeah it does rock ;) i had spent a good hour making a new icon for SFXR and gimp crashed without saving a tmp backup file... lesson learned i will have to start to save my work before any radical changes
Is there anything you're basing your work on, Mikobuntu?
2014-01-28 mikobuntu notifications@github.com
yeah it does rock ;) i had spent a good hour making a new icon for SFXR and gimp crashed without saving a tmp backup file... lesson learned i will have to start to save my work before any radical changes
Reply to this email directly or view it on GitHubhttps://github.com/LMMS/lmms/issues/180#issuecomment-33433986 .
Tobiasz unfa
-----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT/MU/P d->-- s+:-(--)> a? C++(+++)>$ ULC+(++)>$ !P? L+++>++++$ E? W++>$ !N-? !o--? K-? !w-- O? !M-- V? PS++ PE++ !Y+ !PGP+? !t(+) 5? !X !R+ tv b+>+++ DI>+ D+ G e h-->- !r y--() ------END GEEK CODE BLOCK------
I'm just basing the icon on 2 of the colours of the original sfxr , and the idea of an 8bit waveform, I was working at 480 x 480 px and was going to scale it down to the required size, to see if the text "sfxr" was readable at this size, but after the crash i lost all motivation to start over, i may continue this tomorrow, what are your thoughts UNfa, i think the original icon was prob just done in a hurry to get the plugin released?
thanks Mikobuntu ;)
Is there anything you're basing your work on, Mikobuntu?
Tobiasz unfa
-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GIT/MU/P d->-- s+:-(--)> a? C++(+++)>$ ULC+(++)>$ !P? L+++>++++$ E? W++>$
!N-? !o--? K-? !w-- O? !M-- V? PS++ PE++ !Y+ !PGP+? !t(+) 5? !X !R+ tv
b+>+++ DI>+ D+ G e h-->- !r y--()
------END GEEK CODE BLOCK------
— Reply to this email directly or view it on GitHub.
Well I thought I'm gonna give it a try. I don't think it's the best icon ever made, but I'll try anyway:
[image: Obraz w treści 1]
2014-01-28 mikobuntu notifications@github.com
I'm just basing the icon on 2 of the colours of the original sfxr , and the idea of an 8bit waveform, I was working at 480 x 480 px and was going to scale it down to the required size, to see if the text "sfxr" was readable at this size, but after the crash i lost all motivation to start over, i may continue this tomorrow, what are your thoughts UNfa, i think the original icon was prob just done in a hurry to get the plugin released?
thanks Mikobuntu ;)
Is there anything you're basing your work on, Mikobuntu?
Tobiasz unfa
-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GIT/MU/P d->-- s+:-(--)> a? C++(+++)>$ ULC+(++)>$ !P? L+++>++++$ E? W++>$
!N-? !o--? K-? !w-- O? !M-- V? PS++ PE++ !Y+ !PGP+? !t(+) 5? !X !R+ tv
b+>+++ DI>+ D+ G e h-->- !r y--()
------END GEEK CODE BLOCK------
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/LMMS/lmms/issues/180#issuecomment-33438401 .
Tobiasz unfa
-----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT/MU/P d->-- s+:-(--)> a? C++(+++)>$ ULC+(++)>$ !P? L+++>++++$ E? W++>$ !N-? !o--? K-? !w-- O? !M-- V? PS++ PE++ !Y+ !PGP+? !t(+) 5? !X !R+ tv b+>+++ DI>+ D+ G e h-->- !r y--() ------END GEEK CODE BLOCK------
Here's the original.
I did think of sound preview when I develop this plugin. The problem is that there is no pulgin doing so. I worried that this would make plugins in LMMS inconsistent.
Anyway, if users demand this feature, I will implement it.
Let's have a poll here. Also, if you have a better solution, please comment.
I worried that this would make plugins in LMMS inconsistent.
Well. It's rather the synth that's a bit odd in it's nature. You just hit the rand buttons while nodding your head gently. In this machine it would help I think but I'm pretty happy as it is right now.
@wongcc966422 I'm happy right now as the SFXR plugin is. my normal workflow whilst creating any sound on any plugin is to loop a one bar melody and make changes in realtime. Thanks for porting this to LMMS ;)
I think having a sound preview is a good thing. I honestly havent really seen this feature in Logic Pro. This for sure will make LMMS unique, but when you say sound preview are you meaning channel solo where you just hear that instrument?
On Tue, Jan 28, 2014 at 4:30 AM, wongcc966422 notifications@github.comwrote:
I did think of sound preview when I develop this plugin. The problem is that there is no pulgin do so. I worried that this would make plugins in LMMS inconsistent.
Anyway, if users demand this feature, I will implement it.
Let's have a poll here. Also, if you have a better solution, please comment.
Reply to this email directly or view it on GitHubhttps://github.com/LMMS/lmms/issues/180#issuecomment-33448424 .
Jonathan Aquilina
Maybe it's a better idea to implment song preview in core code so that every plugins can have song preview. While most users are happy right now, sound preview may be a good feature. How do you think about it?
I would file a feature request for that.
On Tue, Jan 28, 2014 at 12:54 PM, wongcc966422 notifications@github.comwrote:
Maybe it's a better idea to implment song preview in core code so that every plugins can have song preview. While most users are happy right now, sound preview may be a good feature. How do you think about it?
Reply to this email directly or view it on GitHubhttps://github.com/LMMS/lmms/issues/180#issuecomment-33471895 .
Jonathan Aquilina
but when you say sound preview are you meaning channel solo where you just hear that instrument?
No. Like the preview of presets like it is today but triggered when the sound has been generated. Perhaps it would be good to have some option to not preview when there is a track running and the sound is triggered anyway.
Maybe it's a better idea to implment song preview in core code so that every plugins can have song preview.
But the other sounds are changed incrementally by potentiometer action so it would probably not make as much sense. Unless you also implement random pattern generation for all plugins. That would be fun. One of my favourite software synths amsynth will randomize when you hit '
Mikobuntu, if you're going to create graphics for the UI, I'd ask for you to contact me as I'm keeping tabs on the work assignments on the UI side.
I was actually thinking that the sfxr plugin could use some artwork improvements. If you're interested in working in this area, please contact me so we can coordinate things.
When you generate a new sound with one the random functions it should be instantly played/demoed . At least if the track isn't currently playing.
But the other sounds are changed incrementally by potentiometer action so it would probably not make as much sense...
Oh! I misunderstood it. I thought that you want a sound played when there is any changes on knob. OK. I am now working on sound preview when RAND/MUTA button is clicked.
@diizy @mikobuntu For your reference, this is the source svg file of the background:
On 01/29/2014 03:12 PM, wongcc966422 wrote:
@diizy https://github.com/diizy @mikobuntu https://github.com/mikobuntu For your reference, this is the source svg file of the background: background https://github-camo.global.ssl.fastly.net/8df44909b6691ace7ada738a5684fc9f946581d9/687474703a2f2f696d67682e75732f617274776f726b2e737667
— Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/180#issuecomment-33582962.
Thanks wongcc, that's really helpful! I can probably use that. Do you have anything against moving the phaser knobs a step to the right though? They'd be better aligned that way, creating a more coherent layout.
@diizy It's fine as long as they are aligned(i.e. the x position of phasor knobs have to be identical to any knob on the columns above/below it ).
EDIT: Unaligned knobs is not strictly forbidden. I just want to reduce the changes on the code. :P
On 01/29/2014 03:28 PM, wongcc966422 wrote:
@diizy https://github.com/diizy It's fine as long as they are aligned(i.e. the x position of phasor knobs have to be identical to any knob on the columns above/below it ).
— Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/180#issuecomment-33584001.
Of course. I mean just aligning them one knob column to the right, so the columns are "straight".
@diizy That's fine. Go ahead to do so.
@diizy oops! I've made a typo. That's phaser. Not phasor. Please modify it in the new image. Thanks. :)
On 01/29/2014 04:55 PM, wongcc966422 wrote:
@diizy https://github.com/diizy oops! I've made a typo. That's phaser. Not phasor. Please modify it in the new image. Thanks. :)
— Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/180#issuecomment-33591157.
Way ahead of you - that's the first thing I noticed when I opened it ;)
Anyway, here's what I've got so far. 3 versions, not sure which would be the best direction to go.
Damn, again images not coming through email. Here they are
Love the very last one imho.
On Wednesday 29 January 2014 07:30:09 Vesa V wrote:
Damn, again images not coming through email. Here they are
Reply to this email directly or view it on GitHub: https://github.com/LMMS/lmms/issues/180#issuecomment-33594528
They all looks cool :) Good work!
Before sending a pull request, remember to:
UPDATE: oh. The place holder of RAND and MUTA have gone in the last two. It is not a big deal tho. :P
wow these are great, i prefer the 3rd one down i.e the darker skin :)
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 07:30:09 -0800 From: notifications@github.com To: lmms@noreply.github.com CC: chrissy.mc.1@hotmail.co.uk Subject: Re: [lmms] sfxr - sound preview (#180)
Damn, again images not coming through email. Here they are
— Reply to this email directly or view it on GitHub.
On 01/29/2014 06:42 PM, wongcc966422 wrote:
They all looks cool :) Good work!
Before sending a pull request, remember to:
- Modify the CSS file to change the line color of the knob.
- Modify sfxrInstrumentView::sfxrInstrumentView() in https://github.com/LMMS/lmms/blob/stable-0.4/plugins/sfxr/sfxr.cpp for changing the position of the knobs.
Yep, I will. Although, coincidentally, the same knob line colour will probably work here too.
Hm, I wonder if I should add object names to all the knobs, and do matching lines to the colour rings... as a downside that'd bloat the CSS a bit, but it would look kinda awesome. And it'd be something unique, different from every other instrument so far.
On 01/29/2014 06:44 PM, mikobuntu wrote:
wow these are great, i prefer the 3rd one down i.e the darker skin :)
thanks Mikobuntu ;)
Miko, are you still doing the icon for this? If you are, I'd like to incorporate your icon design to the artwork, maybe as a background element, or a replacement for that bar graphic in the top right.
Yes i can work on the icon tonight, is .png format ok, i usually work in gimp as i havnt used vector apps much yet ?
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 08:48:12 -0800 From: notifications@github.com To: lmms@noreply.github.com CC: chrissy.mc.1@hotmail.co.uk Subject: Re: [lmms] sfxr - sound preview (#180)
On 01/29/2014 06:44 PM, mikobuntu wrote:
wow these are great, i prefer the 3rd one down i.e the darker skin :)
thanks Mikobuntu ;)
Miko, are you still doing the icon for this? If you are, I'd like to
incorporate your icon design to the artwork, maybe as a background
element, or a replacement for that bar graphic in the top right.
— Reply to this email directly or view it on GitHub.
On 01/29/2014 06:57 PM, mikobuntu wrote:
Yes i can work on the icon tonight, is .png format ok, i usually work in gimp as i havnt used vector apps much yet ?
thanks Mikobuntu ;)
Yes it's ok. The image should be 48x48 pixels.
thats cool, i will get to work on the icon now, 1 question, should i stay close to the colours of the original sfxr app or perhaps just try to tie it into something which i think will suit the new theme. I will of course have a few variants for sure anyway ?
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 10:20:12 -0800 From: notifications@github.com To: lmms@noreply.github.com CC: chrissy.mc.1@hotmail.co.uk Subject: Re: [lmms] sfxr - sound preview (#180)
On 01/29/2014 06:57 PM, mikobuntu wrote:
Yes i can work on the icon tonight, is .png format ok, i usually work
in gimp as i havnt used vector apps much yet ?
thanks Mikobuntu ;)
Yes it's ok. The image should be 48x48 pixels.
— Reply to this email directly or view it on GitHub.
On 01/29/2014 08:23 PM, mikobuntu wrote:
thats cool, i will get to work on the icon now, 1 question, should i stay close to the colours of the original sfxr app or perhaps just try to tie it into something which i think will suit the new theme. I will of course have a few variants for sure anyway ?
thanks Mikobuntu ;)
I don't know, if we go with the 2nd/3rd design (3rd seems most popular atm), then the original colours probably won't fit the artwork that well.
I'll probably go with the 3rd variant (the dark grey/black one).
I was just looking at the images and I 100% prefer the 3rd design, so i can start now and base my logo on these colours.. the last logo i did was for the sid player, i didnt spend much time on it tho :)
thanks Mikobuntu ;)
I don't know, if we go with the 2nd/3rd design (3rd seems most popular
atm), then the original colours probably won't fit the artwork that well.
I'll probably go with the 3rd variant (the dark grey/black one).
— Reply to this email directly or view it on GitHub.
On 01/29/2014 09:47 PM, mikobuntu wrote:
I was just looking at the images and I 100% prefer the 3rd design, so i can start now and base my logo on these colours.. the last logo i did was for the sid player, i didnt spend much time on it tho :)
You did? Did you do the SID artwork too? It's kind of awesome... I really like it. Only the title was a bit shabby, so I fixed it a bit ;)
No i just did the logo, as there was an issue about the copyright of the original logo, true tho the artwork is awesome, It took your adjustments on the title to make it look better imo. Im playing about with ideas here for SFXR, im not sure if we need the letters "sfxr" in the logo, what do you think? i like the placement of your graph in your artwork already, maybe it could stay and my logo fit in somewhere else, but i see there may not be much space to have it look right tho
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 12:33:56 -0800 From: notifications@github.com To: lmms@noreply.github.com CC: chrissy.mc.1@hotmail.co.uk Subject: Re: [lmms] sfxr - sound preview (#180)
On 01/29/2014 09:47 PM, mikobuntu wrote:
I was just looking at the images and I 100% prefer the 3rd design, so
i can start now and base my logo on these colours.. the last logo i
did was for the sid player, i didnt spend much time on it tho :)
You did? Did you do the SID artwork too? It's kind of awesome... I
really like it. Only the title was a bit shabby, so I fixed it a bit ;)
— Reply to this email directly or view it on GitHub.
On 01/29/2014 10:43 PM, mikobuntu wrote:
No i just did the logo, as there was an issue about the copyright of the original logo, true tho the artwork is awesome, It took your adjustments on the title to make it look better imo. Im playing about with ideas here for SFXR, im not sure if we need the letters "sfxr" in the logo, what do you think? i like the placement of your graph in your artwork already, maybe it could stay and my logo fit in somewhere else, but i see there may not be much space to have it look right tho
I'm not sure if fitting sfxr on the logo works... you need to remember that it gets shrunk down to 24x24 when it's on the instrument track, so if it's not clear at that size, then it doesn't work. That's the thing about logos, you need to make a 48x48 image that looks good in both full size and half size (or is that quarter... 50% zoom anyway)
I think some kind of simple graphic might work best here. Something that brings in mind 8-bit sound effects and chiptunes maybe... Star? Mushroom? Flower? Coin? 1up? I don't know... something like that?
ok thanks, that has made it clearer for me now, ;)
thanks Mikobuntu ;)
I'm not sure if fitting sfxr on the logo works... you need to remember
that it gets shrunk down to 24x24 when it's on the instrument track, so
if it's not clear at that size, then it doesn't work. That's the thing
about logos, you need to make a 48x48 image that looks good in both full
size and half size (or is that quarter... 50% zoom anyway)
I think some kind of simple graphic might work best here. Something that
brings in mind 8-bit sound effects and chiptunes maybe... Star?
Mushroom? Flower? Coin? 1up? I don't know... something like that?
.
ive just had a flash of inspiration , i now know what i am going to design for the logo ;)
thanks Mikobuntu ;)
I think some kind of simple graphic might work best here. — Reply to this email directly or view it on GitHub.
Mushroom it is then ... hope you all like it, i have the .xpf files if anyone wants to improve on the icon... i will attach it here..let me know if it goes through ok and if not i will attach it directly on github EDIT logo.png now attached here ...
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 12:52:49 -0800 (https://f.cloud.github.com/assets/335217/2035613/997196ae-893c-11e3-9fab-f13f7620e7f2.png)
http://f.cloud.github.com/assets/335217/2035193/90fb98a4-8936-11e3-8462-72afabaad09c.png
I think some kind of simple graphic might work best here. Something that
brings in mind 8-bit sound effects and chiptunes maybe... Star?
Mushroom? <<<<<<<— Reply to this email directly or view it on GitHub.
On 01/30/2014 12:39 AM, mikobuntu wrote:
Mushroom it is then ... hope you all like it, i have the .xpf files if anyone wants to improve on the icon... i will attach it here..let me know if it goes through ok and if not i will attach it directly on github
thanks Mikobuntu ;)
Nope you have to reply on github if you want images to go through... they won't go via email.
ok thanks done now ;)
thanks Mikobuntu ;)
Nope you have to reply on github if you want images to go through...
they won't go via email.
— Reply to this email directly or view it on GitHub.
On 01/30/2014 12:44 AM, mikobuntu wrote:
ok thanks done now ;)
thanks Mikobuntu ;)
Hmm, that certainly looks very good, but the way it is now it doesn't really remind much of sfxr.. I was thinking maybe you could do it in an 8-bit style? You know, pixelated, and all that... maybe somewhat like the bitinvader logo?
i could probably make it look pixelated, i think there are gmic plugins within gimp that can do something to this effect,. i do think the mushroom and its colours stand out nicely tho, and it ties in nicely with the organic logo too imo ;)
thanks Mikobuntu ;)
Date: Wed, 29 Jan 2014 14:47:22 -0800 From: notifications@github.com To: lmms@noreply.github.com CC: chrissy.mc.1@hotmail.co.uk Subject: Re: [lmms] sfxr - sound preview (#180)
On 01/30/2014 12:44 AM, mikobuntu wrote:
ok thanks done now ;)
thanks Mikobuntu ;)
Hmm, that certainly looks very good, but the way it is now it doesn't
really remind much of sfxr.. I was thinking maybe you could do it in an
8-bit style? You know, pixelated, and all that... maybe somewhat like
the bitinvader logo?
— Reply to this email directly or view it on GitHub.
On 01/30/2014 12:53 AM, mikobuntu wrote:
i could probably make it look pixelated, i think there are gmic plugins within gimp that can do something to this effect,. i do think the mushroom and its colours stand out nicely tho, and it ties in nicely with the organic logo too imo ;)
thanks Mikobuntu ;)
Well sure it looks good and has nice colours... but the thing is, in organic, the carrot is sort of a funny reference to the name "organic" - like, organic foods, and such. Here, I worry that the mushroom isn't immediately obvious as to what it's a reference to... if it looked more "videogamey", then people would instantly get it that "oh, it's a 1up-mushroom".
Could you maybe just make an 8-bit version so we could compare which one looks better?
yes i can understand what you mean ;) yes im working on it now, if it is not suitable tho do not worry as i enjoy working in gimp, but i certainly would like to contribute this logo as i am mainly a tester and bug reporter, and i have written 1 line of code for lmms, oh and not fogetting the nice opacity fade i did for the tooltips lol ..
thanks Mikobuntu ;)
Well sure it looks good and has nice colours... but the thing is, in
organic, the carrot is sort of a funny reference to the name "organic" -
like, organic foods, and such. Here, I worry that the mushroom isn't
immediately obvious as to what it's a reference to... if it looked more
"videogamey", then people would instantly get it that "oh, it's a
1up-mushroom".
Could you maybe just make an 8-bit version so we could compare which one
looks better?
— Reply to this email directly or view it on GitHub.
pixelated:-
original:-
not too sure about how this will look, i would probably be better starting fresh and set out to make a pixelated image tho ... but here it is anyway ^^^
On 01/30/2014 01:24 AM, mikobuntu wrote:
mushroom3pixelated https://f.cloud.github.com/assets/335217/2035571/442c00d0-893c-11e3-9bfd-de7974071d4c.png
not too sure about how this will look, i would probably be better starting fresh and set out to make a pixelated image tho ... but here it is anyway ^^^
— Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/180#issuecomment-33643812.
Hm, yeah, you're probably right. Still not quite getting the "1up mushroom vibe" out of this... Maybe try something simpler, go without any anti-aliasing, limit the palette to just a handful of colours... Maybe if you were to make it really simple, sort of iconic, no 3d perspective or anything, just simple shapes... does any of this make sense? Kind of how bonus icons and such were designed in early video games, or something...
In a nut shell vesa is saying make it 2d and flat
On Thu, Jan 30, 2014 at 1:01 AM, Vesa V notifications@github.com wrote:
On 01/30/2014 01:24 AM, mikobuntu wrote:
mushroom3pixelated < https://f.cloud.github.com/assets/335217/2035571/442c00d0-893c-11e3-9bfd-de7974071d4c.png
not too sure about how this will look, i would probably be better starting fresh and set out to make a pixelated image tho ... but here it is anyway ^^^
Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/180#issuecomment-33643812.
Hm, yeah, you're probably right. Still not quite getting the "1up mushroom vibe" out of this... Maybe try something simpler, go without any anti-aliasing, limit the palette to just a handful of colours... Maybe if you were to make it really simple, sort of iconic, no 3d perspective or anything, just simple shapes... does any of this make sense? Kind of how bonus icons and such were designed in early video games, or something...
Reply to this email directly or view it on GitHubhttps://github.com/LMMS/lmms/issues/180#issuecomment-33646616 .
Jonathan Aquilina
yeah guys i have grasped the idea, yous will have to give me until tomorrow night 00;05 here uk time and work in the morn, but that will give me plenty of time to work out some good ideas :)
When you generate a new sound with one the random functions it should be instantly played/demoed . At least if the track isn't currently playing.