search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.12k stars 1k forks source link

VST tuning off #2085

Closed Moth-Tolias closed 5 years ago

Moth-Tolias commented 9 years ago

I have tested several VSTs. Many seem to have a tuning bug where they are, well... pitch a Triple Oscillator, playing a single sinewave at C (in tune)

pitch b Glureeds VST, playing at C (out of tune)

The MTuner vst plug-in shows that the vsts "think" that their tuning is correct. However, I have compared the output of TripleOsc with several commercial samples, as well as Audacity's Tone Generator, and found it to be in tune.

Mtuner also agrees with another tuner VST, Gtune. both report identical values with the same offset.

Windows 64-bit, version 1.1.3. Appears not to happen in 32-bit, though It's been a while since I last checked.

Umcaruje commented 9 years ago

Hi, have you tried loading the VST's in some other DAW (Reaper or FL Studio) and checking if they register out of tune there too? If that is the case, then that's not our bug, and it can only be fixed by the plugin developers.

Moth-Tolias commented 9 years ago

Downloading the demo of FL studio now, will report later.

smokedawg17 commented 9 years ago

i dont know where to post this, but why dont you guys look into making everything microtonal.. even the vestige plugins like they do on logic. Ive seen a max plugin for ableton that you can midi detune for microtonal music on all vst's, i think that would be a super feature to bring lmms to the top! dont mind me just popping by (A4=432hz, pythagorean ratios accross 12 notes MAGIC)

Umcaruje commented 9 years ago

@Moth-Tolias did you ever test these plugins in some other daw?

tresf commented 9 years ago

@smokedawg17 is your request covered by #1472 (last enhancement item), per #1387?

softrabbit commented 9 years ago

Looks like it's a case of 44100 vs 48000 Hz.

44100/48000 = 0.91875, plug that in to the calculator at http://www.sengpielaudio.com/calculator-centsratio.htm and you get -146.7, which is a semitone and 47 cents down, fits exactly with the first screenshot.

And to be specific, this would mean LMMS runs at 48000 while VSTs think they run at 44100, leading to a "slowed tape" effect.

Moth-Tolias commented 9 years ago

@Umcaruje not yet, sorry. I've almost learnt FL to the point where I can test and report back, but a lot of school deadlines have been coming in and I simply haven't had the time to spare

softrabbit commented 9 years ago

I have 0 experience with VST on LMMS, but the first spot I'd try is removing the if clause: https://github.com/LMMS/lmms/blob/master/plugins/vst_base/RemoteVstPlugin.cpp#L578 and just call updateSampleRate(); for all plugins. That check might of course be there for a reason, but I guess it doesn't hurt (much) to try.

Moth-Tolias commented 9 years ago

I can now confirm that the affected VSTs running in FL studio return a different pitch to that in LMMS.

DomClark commented 5 years ago

@Moth-Tolias Can you test the latest beta version to see if this issue still persists? Some issues relating to VST pitch errors have been addressed recently.

Moth-Tolias commented 5 years ago

thanks for letting me know, i'll take a look.

Moth-Tolias commented 5 years ago

looks as though this bug at least is fixed, thank you.