LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.98k stars 995 forks source link

Impact Zone plug-in #2134

Closed Reaper10 closed 8 years ago

Reaper10 commented 9 years ago

Edited 9/12/2015 by @tresf, fix formatting

Impact Zone plug-in

The Master Section

The Pads

Presets

Plug-in Modules

Synth Plug-ins

The Gear Menu (options found in the gear menu)

  1. Remove module
  2. Copy pad to 1-16
  3. All midi options
  4. Add default Modules list
  5. After Add support for acidized samples #2154 is added a user can use one AFP / sample on all 16 pads.
grejppi commented 9 years ago

Is there anything this plugin can do that you couldn't already do with the Beat/Bassline editor?

From a technical view, the keyboard widget isn't something that you can't take away from an instrument, because it is not part of an instrument plugin in the first place. This proposal would either require a near-complete overhaul of the instrument API, or a completely new track type (not good). Oval knobs are unlikely to happen either.

Reaper10 commented 9 years ago

Feel free to chage what need just an idea

grejppi commented 9 years ago

When would you like to see this implemented?

Reaper10 commented 9 years ago

when ever you can

Reaper10 commented 9 years ago

can you keep the name?

tresf commented 9 years ago

The author of the plugin would have to decide that., but the name isn't bad. It is catchy and very appropriate, so you may get your wish if it ever comes to fruition.

grejppi commented 9 years ago

In my opinion LMMS could benefit more from a general purpose layer plugin, or at least something along the lines of "note sends" analogous to audio sends in the mixer. But that'd be the subject for a different issue.

We already have a way to use our instrument plugins as drums, and it is called the Beat+Bassline Editor. In my opinion a new plugin for that would be completely redundant.

Reaper10 commented 9 years ago

shoud I close this

tresf commented 9 years ago

I disagree strongly. A drum pad as mentioned several times over and present in many DAWs is needed IMO. Perhaps not so much from a functionality perspective.... as we can achieve the effect in several ways already as you've mentioned.... This would be more of a productivity improvement per #1460

softrabbit commented 9 years ago

Edited the OP a bit to make a few spots more readable.

First impression: why the 4x4 grid interface? What's wrong with a list that can be as long as it needs to be, like in the B&B-editor? Is it because some other software looks like this or is it to mimic some famous piece of hardware?

rubiefawn commented 9 years ago

So like Ableton's Drum Rack? This would be nice, especially since many MIDI files organize percussion in a single track. Not having to separate them would save hours of time when importing MIDI.

tresf commented 9 years ago

So like Ableton's Drum Rack?

Yes.

softrabbit commented 9 years ago

I think this could be realized as a kind of a "view" on the B&B-editor, as the underlying idea is related, a container for instruments. And this could even become a more general purpose layer plugin with just one small modification: allow for note ranges instead of just one note per pad.

What functionality is missing along that line? Off the top of my head these are most obvious:

In broad terms it should then be mostly a matter of broadcasting the note data from the track onto all the instruments once those few points are solved.

And a few negative points:

rubiefawn commented 9 years ago

I think implementing it as a plugin would be more useful. Again, many MIDI files have all percussion in the same MIDI track, and if this is realized as a plugin there will be no need to separate the percussion tracks (which takes a very long time.) But I can't code so whatever you devs decide on will be okay. I would just prefer a Drum Rack.

On Mon, Jul 6, 2015 at 5:07 AM, Raine M. Ekman notifications@github.com wrote:

I think this could be realized as a kind of a "view" on the B&B-editor, as the underlying idea is related, a container for instruments. And this could even become a more general purpose layer plugin with just one small modification: allow for note ranges instead of just one note per pad.

What functionality is missing along that line? Off the top of my head these are most obvious:

In broad terms it should then be mostly a matter of broadcasting the note data from the track onto all the instruments once those few points are solved.

And a few negative points:

  • @Reaper10 https://github.com/Reaper10, I think most of us got the point from one instrument plugin mockup. You provide 9, all with the exact same modifications.
  • How is changing the root note supposed to work if the piano is removed from the instrument UI? If e.g. a pad should react on an incoming C5 but you want to send A4 to the instrument...

— Reply to this email directly or view it on GitHub https://github.com/LMMS/lmms/issues/2134#issuecomment-118818572.

tresf commented 9 years ago

many MIDI files have all percussion in the same MIDI track, and if this is realized as a plugin there will be no need to separate the percussion tracks (which takes a very long time.)

:+1:

softrabbit commented 9 years ago

if this is realized as a plugin there will be no need to separate the percussion tracks

That option wasn't really in my mind, as I said "broadcasting the note data from the track onto all the instruments". Yes, it could be easier to get all the notes into a plugin which then hosts other plugins, but it shouldn't be impossible in some other solution either.

tresf commented 9 years ago

Please stop cross-post bumping.

tresf commented 9 years ago

@Reaper10 I'd like to reinforce a few things here...

  1. This is probably the most comprehensive enhancement you've written (thanks).
  2. It is still a disaster and took about 15 minutes of cleanup because you are failing to exercise a standard level of readability to your bug reports.

I just cleaned up the original post and here are the results:

Before

After

This sets a bad example for our tracker and creates topics that are simply too long to read. We have too many developers working toward progress and change to allow our tracker to become a garbage collector of @Reaper10's wishes. We all have wishes, and if you want them to come true, you should show more appreciation to the tracker.

Reaper10 commented 9 years ago

i'm sorry I just can't seem to get this right.:(

tresf commented 8 years ago

Closing this as it is wishful thinking, but no plan exists to actually code and implement. Please reference or re-open if status changes.