search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.08k stars 1.01k forks source link

Asymmetric operation mode for waveshaper #2208

Open unfa opened 9 years ago

unfa commented 9 years ago

I got the idea after watching this video:

https://www.youtube.com/watch?v=nj3st4lmKKo

The guy says about importance of asymmetrical waveshaping in sound design. I feel our great Waveshaper plugin could benefeit from this wisdom.

What do you think?

zonkmachine commented 9 years ago

What do you think?

:+1: You can just add a knob in there to add a linear value to the input. Is that what you're thinking of? That's( probably ) an easy hack.

I've actually thought about making a plug in for this that you can stick in front of whatever other unit you think is, well, too straight.

unfa commented 9 years ago

I rather thouoght about adding kind of 0,5 DC offset, so the 0 will be right in the middle (also chaning the plugin's GUI would be nice), but I'd add this as a switch, not knob, however the knob could give some awesome automation capabilities if it was RT-safe and zipper-noise free.

Umcaruje commented 9 years ago

however the knob could give some awesome automation capabilities if it was RT-safe and zipper-noise free.

AFAIK the zipper noise happens because if there is no sample-exactness, not because of RT-safety.

zonkmachine commented 9 years ago

I rather thouoght about adding kind of 0,5 DC offset

Yes, DC offset is what I meant with 'linear value' above.

unfa commented 9 years ago

@Umcaruje Thanks for explanation! This may explain why I still experience bad clicks with Peak Controller, even though the issue is supposed to be already fixed (I found a workaround - using Calf Filter which has internal time-smoothing called "interia" and fixes the clicks).

Umcaruje commented 9 years ago

@unfa the issue is fixed on some places in master, and it affects only native plugins. IIRC LADSPA does not support sample exactness.

If you want to see progress on the sample exactness implementation check out issue #402

unfa commented 9 years ago

@Umcaruje thanks!

zonkmachine commented 8 years ago

OK. I had a go at this. I went with +/- 0.5 as you suggested.