Switching to Qt5

[tresf]

Many of our users are already compiling against Qt5, but most of them tend to be on Linux. This topic is related to switching all builds to Qt5 permanently and what's needed prior to that switch.

• For starters, we need more testing.
  • Our first Win64 build which utilizes Qt5 is located here:
    (removed, please download 1.2.0 from the downloads page)
  • Our first Mac build which utilizes Qt5 is located here:
    (removed, please download 1.2.0 from the downloads page)
• Bugs (please check these off as they're fixed)
  • [x] All: Frequent crashes related to QVector https://github.com/LMMS/lmms/issues/2192#issuecomment-193905099.
  • [x] Mac: Spash window appears above SettingsDialog, MessageDialog (fixed via 1058ea4)
  • [x] All: Visual artifacts in MDI window decorations (preview) (superseded by #2516)
  • [x] All: Menu bar colors are hard to read (preview) (fixed via 5f48d1c)
  • [x] All: Inactive QMdiWindow titles are hard to read (preview) (superseded by #2516)
  • [x] All: Language dropdown is blank (fixed via https://github.com/LMMS/lmms/commit/85011cdcf72fbba721bb0c10f140bfabf7a35725)
  • [x] All: White line on edge of all QWidgets (preview) (superseded by #2516)
  • [X] All: QMdiWindow windowing controls are incorrectly colored (preview) (wont-fix, see https://github.com/LMMS/lmms/issues/2611#issuecomment-193942180)
  • [x] All: Channel activity indicator on by default (fixed via 8768769)
  • [x] All: Drop-down menus are "crammed" (fixed via https://github.com/LMMS/lmms/commit/d098a39c76321293af73f398ab89965e827b4d12)
  • [x] All: Colors incorrect for about dialog (preview) (fixed via #2781)
  • [x] All: Crash when removing a channel that sends to another channel (#2667)
  • [x] Windows: Fix high-CPU usage for collapsed toolbars (#2767)
  • [x] All: VSTs GUI does not load properly (#2855) - Still open but will not affect Windows, Mac (fixed via #3786)
  • [x] Mac: ⌘ + drag shortcuts are broken (#2890) (old Xcode version only, not our bug, 1.2.0-RC5 seems to have fixed this for the 10.13+ builds)
  • [x] Remove Mac/Windows Qt4 builds from Travis-CI

Screenshot, because everyone loves screenshots...

[simonvanderveldt]

Will building with Qt4 as an option be removed? (I'm on Linux in case it's relevant)

[tresf]

Will building with Qt4 as an option be removed?

No, not right away as VST GUIs are still horribly broken with Qt5 on Linux. #2855.

We do have plans to shift Windows and Mac builds to Qt5 since they have Qt5 bundled --there is no downside. Note, we may eventually offer Qt5 bundles for Linux as well per #2932, assuming VSTs are sorted.

[simonvanderveldt]

:thumbsup:

[tresf]

New issue... #2890 Qt5 prevents Mac ⌘+Drag copy as well as Mac ⌘+Drag to Automation editor.

Although Copy/Paste has a right-click alternative, no such shortcut exists for linking to an automation pattern.

This may be unrelated to Qt5 (could be a code change) but my instinct is that it's directly Qt5 related.

Edit: It seems to be related to the XCode SDK used for building. For now, ALT + Option works just fine.

[musikBear]

That "Drive not ready" thing? -that appears when lmms is loaded. I suspect that it is an error caused by the absence of a disk in Drive-B, or iow. This popup will occur, if the user do not have a SSD in drive-B, and the compiling is made on a system with a drive-B. Could that be correct?

[tresf]

Could that be correct?

Nope.

[tresf]

Closed via #4041. The last remaining item was switching Travis to Qt5 and that is completed.