search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.83k stars 988 forks source link

LMMS Automation gets destroyed after exporting song to WAV #27

Closed eagles051387 closed 10 years ago

eagles051387 commented 10 years ago

Produce this bug like this: Add a GLAME Butterworth Lowpass Filter to the Master Drag its automation to an automation channel Draw in there some fancy figures Export to wave. At start, the whole automation channel is set to 1, everything you have drawn will be erased. Bug has been found with 0.4.15 and with current git.

Johannes Lorenz: This bug also occurs if I append one project to another one (I commented out the line "clearProject();" in song::loadProject()). When all tracks are loaded, the automation is completely erased. The bug even occurs on the first load of any file (e.g. not an append), when I outcomment "AutomationPattern::resolveAllIDs();". Thus I assume that the bug is caused since a second call to "AutomationPattern::resolveAllIDs();" fails, but a first does not. So the AutomationPattern might not be cleaned correctly. Can someone please help me with this issue?

Raine M. Ekman: Some more observations: The automation editor and the track will only show a range of 0...1 but the data is still there after the export, copy the automation and it will show up again. And it will play just fine even when "invisible". Also, after export the number of connections on the automation segment goes up from 1 to e.g. 4 (but only 1 visible in the context menu). That might be related somehow? Automating track volume/pan knobs doesn't seem to be affected by this bug.

Stian Jørgensrud: ^ You can just save and reopen. The information is not lost, only the graphics in that instance of LMMS.

Sti2nd commented 10 years ago

This still applies with the above steps, and in addition I notice that it says "4 connections" but only lists the one GLAME frequency.

So I guess it is as simple as refreshing the automation GUI after export? Or perhaps this doesn't fix the "4 connections", so maybe find out why it suddenly says 4 connections?

SadaleNet commented 10 years ago

Can anyone reproduce this now? It seems that it's fixed. I have no idea on which commit fixes this tho.

EDIT: never mind.

SadaleNet commented 10 years ago

working on it

SadaleNet commented 10 years ago

Done. Please test it. If this commit does not introduce new bugs, https://github.com/LMMS/lmms/issues/124 would be the final boss before the 1.0.0 release. :D