search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.13k stars 1.01k forks source link

Piano Roll Black Keys Contrast #3018

Closed tresf closed 8 years ago

tresf commented 8 years ago

It is too hard to tell when a black key is being pressed or not in the piano roll.

Although this may seem minor when clicking with the mouse, this is much more severe when using the typing keyboard as the notes being played are much less obvious from a UI perspective.

untitled

vlad0337187 commented 8 years ago

I only now thought, how it's great that my favorite program was based on my feedback. You, bourgeois, possibly dislike communism, but free software world is very similar to it =) Thanks.

simonvanderveldt commented 8 years ago

Will this just need pixmap changes or code changes as well?

RebeccaDeField commented 8 years ago

@simonvanderveldt Just pixmap changes, which is something that I am currently working on. If all goes well with my most recent tweaks for alignment, you should be seeing a pull request for this soon. :+1:

simonvanderveldt commented 8 years ago

@RebeccaDeField Awesome! Just checking if you'd need some help with the code, but even better when the changes are limited to the pixmaps, makes it easier :)

RebeccaDeField commented 8 years ago

@simonvanderveldt Thank you. I really appreciate you checking in and I will be sure to reach out to you if I have any coding requests that are beyond my abilities. :)