search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.14k stars 1.01k forks source link

Loop enabled/disabled button should be more obvious #3069

Open tresf opened 8 years ago

tresf commented 8 years ago

The enable/disable loop points button is a bit backwards. It's gray-ed out when it's inactive and just "regular" when it's active.

At a glance, this makes it hard to know when the loop points are enabled:

screen shot 2016-10-08 at 11 53 37 am

Gray-ed out from a UI perspective generally means it's not accessible. I think instead, the loop points should behave more like an LED toggle and be very obvious when enabled.

screen shot 2016-10-08 at 11 53 37 am

This way when a composer finds their project arbitrarily jumping away from the cursor area, they have a visual indicator as to why.

zonkmachine commented 4 months ago

@zonkmachine how viable is it to add this change too to #7314

I'll look into it.

zonkmachine commented 4 months ago

looppoints

Something like this? It's just a matter of editing the colors of loop_points_on.png

Rossmaxx commented 4 months ago

Nope, more like changing the button's background colour to highlight to green

Refer https://github.com/LMMS/lmms/issues/3069#issuecomment-660675527

zonkmachine commented 4 months ago

Nope, more like changing the button's background colour to highlight to green

Similar how the modes draw/knife/edit in the editor change background when selected? Darker on the Default theme and lighter on Classic.

actions

Rossmaxx commented 4 months ago

Similar but the active background should be green like in the linked comment above.

zonkmachine commented 4 months ago

Similar but the active background should be green like in the linked comment above.

Yes, I occasionally do green. I don't get where that background is set in the case of the edit buttons though?

Rossmaxx commented 4 months ago

It's currently not available for theming. https://github.com/LMMS/lmms/issues/3069#issuecomment-264476113 in combination with a theme entry should do the trick.