LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.05k stars 1k forks source link

Invert menu icons when white icon on light background or black icon on dark background #3362

Open follower opened 7 years ago

follower commented 7 years ago

See https://github.com/LMMS/lmms/issues/3349#issuecomment-279477069:

I just read a bug report with users complaining about this identical behavior, except when in dark mode. Apparently there's an unmerged feature to help... https://codereview.qt-project.org/#/c/115120/

Linked from https://bugreports.qt.io/browse/QTBUG-42109.

For the short-term, we can use a quick hack, such as inverting the color palette for these icons. http://doc.qt.io/qt-5/qimage.html#invertPixels

When #3349 is closed this issue will apply to new default theme icons for templates and project files only on macOS/OS X.

tresf commented 7 years ago

When #3349 is closed this issue will apply to new default theme icons for templates and project files only on macOS/OS X.

Fortunately #3349 drastically reduces the severity of it by removing them on all of the main menus. 👍

shimpe commented 7 years ago

I don't know if this is the same problem, but it's surely annoying

iconsinvisible

musikBear commented 7 years ago

@shimpe we need more and better information please post your:

shimpe commented 7 years ago

Sorry you are right I should have known that.

OS: arch linux 64bit, latest updates LMMS: latest master ebfdc0491afc896b24372ff39d51b0506dde109d; lmms itself reports: "version 1.2.0-rc3.100 (Linux/x86_64, Qt 4.8.7, GCC 7.1.1 12-20170630" HW specification: probably not relevant for a GUI problem, but anyway laptop with 16GB ram and built-in intel sound card 00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor HD Audio Controller (rev 06) Name of theme: no idea (it's quite dark though :)). I didn't realize one can choose a theme. I'll try to find if I can select different ones, maybe that will work around the problem for now (it should probably still be solved though).

shimpe commented 7 years ago

Turrns out I was using "default theme". When I switched to classic, the dialog looks better but still has one icon that is barely visible. (See screenshot) iconsinvisible2