search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.14k stars 1.01k forks source link

Min/Max values for controllers #3690

Open gi0e5b06 opened 7 years ago

gi0e5b06 commented 7 years ago

Hi,

When going live, some controllers must stay in a certain range. It's not finished (no load/save) but it seems my little patch is working. I modified MidiPort, MidiController and ControllerConnectionDialog. IMHO, it's very useful.

Sincerely, G.

gi0e5b06 commented 7 years ago

backup_20170711

Backup_20170711.zip

zonkmachine commented 7 years ago

I'll have a look at this after 1.2 is released. You need to fork the project and create a pull request. Just press the fork button, top/right next to the watch/starred buttons on this page. The rest is in our wiki. Here is a related discussion: https://github.com/LMMS/lmms/issues/2313

BaraMGB commented 7 years ago

Looks good, but we accept patches only per Pull Request in github.

gi0e5b06 commented 7 years ago

Thanks for the answers. I'm new to Git, I tried to use it 3 days ago, without success. Will tried again later. I got my midimix 4 days ago, looked for the first time the lmms source code 3 days ago so I probably didn't code things the right way. I'm posting again an archive but for reference only. Anyway, buttons are now supported (knobs and sliders already were) so I can mute/solo the tracks easily. I can also use keys to control parameters. Still no load/save. The main point was to remove code in #3694. BTW, I have a few other (technical) ideas to discuss/implement. What is the best place to post? Here or in the forum? Backup_20170712.zip

zonkmachine commented 7 years ago

BTW, I have a few other (technical) ideas to discuss/implement. What is the best place to post? Here or in the forum?

Most lmms coders hang out on Discord: https://discord.gg/3sc5su7

PhysSong commented 6 years ago

Related: #1950

gi0e5b06 commented 6 years ago

@PhysSong Yes. But there are two different concerns: 1) How to interpret/filter MIDI events 2) How to configure a LMMS controller (min, max, cur, reset values and scale) Each of these concerns needs its own dialog, IMHO.