LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.14k stars 1.01k forks source link

LMMS steals focus when loading #3769

Open Spekular opened 7 years ago

Spekular commented 7 years ago

Not sure of the proper wording for this. If another window is in focus while LMMS loads, LMMS will regain focus whenever a new part of loading completes. I believe this is undesirable.

Tested on Windows 10 with 1.2.0-rc2

musikBear commented 7 years ago

Confirming for rc3 x32 Its quite amusing, because i was actually getting aware of this 'problem' yesterday. RC3 loads projects quite slow on my 2 cpu 10y old pc, so i wanted to check mail. Lmms broke in every time a VST was 'successfully loaded'. 🤡 Buuu..t i would hardly call this a bug, most with good hw wont be bothered at all imo: can wait to 1.2.x

Spekular commented 7 years ago

I'd say it's bad either way. I have projects slow enough (especially with VSTs) to want to do something else, and that's with an i5-4590 and projects

On Aug 15, 2017 16:56, "musikBear" notifications@github.com wrote:

Confirming for rc3 x32 Its quite amusing, because i was actually getting aware of this 'problem' yesterday. RC3 loads projects quite slow on my 2 cpu 10y old pc, so i wanted to check mail. Lmms broke in every time a VST was 'successfully loaded'. 🤡 Buuu..t i would hardly call this a bug, most with good hw wont be bothered at all imo: can wait to 1.2.x

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LMMS/lmms/issues/3769#issuecomment-322492654, or mute the thread https://github.com/notifications/unsubscribe-auth/AIgVmvv5T1Kap4NOGXfnRP20fvjbvBgEks5sYbGWgaJpZM4O3fWy .

musikBear commented 7 years ago

and that's with an i5-4590 and projects + LMMS on an SSD.

wooo... ok, thats surprises me, other have talked about benchmarks around 5-10 secd, for even large project, like unfa spoken Was better in 1.0..

tresf commented 6 years ago

Does it go away if you comment out the call to show() and replace it with:

if (!pd->isVisible()) { pd->show(); }

https://github.com/LMMS/lmms/blob/ee9b593e263188913b81bacbc0258310940ce0fa/src/core/TrackContainer.cpp#L101

PhysSong commented 6 years ago

It seems like QWidget::show activates the target window unless WA_ShowWithoutActivating is set.

PhysSong commented 6 years ago

And also QWidget::setVisibility(true)...