search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.04k stars 1k forks source link

Toolbar vertical real-estate enhancement #387

Open tresf opened 10 years ago

tresf commented 10 years ago

A proposal for the toolbar to reclaim some unused screen real-estate.

image

Left aligned tool menu items: Make the file and project toolbar buttons a single row that is capable of overflowing into a second row if needed. image

Right aligned tool menu items: Make the remaining components a single row that is capable of overflowing into a second row if needed.

  1. All time-related items in a single row (BPM, time sig, clock)
  2. Master volume/master pitch rotated horiz (single row height)
  3. Optionally consolidate min/sec/millisec into a single "clock"
  4. Visualization shorter (single row height)
  5. CPU vertical, shorter (single row height) image

File menu hidden All menu items consolidated into a single quick-access menu. This is no less clicks than the current menu and finds a better place for single-item menus such as LADSPA or Settings. Most items already have dedicated toolbar buttons, encourages their usage. Chrome menu button used only as example. image

The big picture: All changes combined into a single mock-up. Notice the master volume is frozen to the top right, for quick accessibility. image

Additional Notes

I would personally recommend removing the CPU and visualization from the default view and instead offer these as FX visualization plugins. Alternately, a basic CPU/MEM indicator might be a good alternative.

-Tres

davidgerard commented 10 years ago

Goodness yes. More vertical real estate, please! Narrower tracks would be useful as well.

AndiEcker commented 10 years ago

+1 ((btw: loving to see the amazing team work of all you guys in the past months!!! you're doing a great job!!! Big Ups!!! Thousand thanks, love and hugs to all of you <3 <3 <3))

diizy commented 10 years ago

This is very similar to a mock-up I made earlier...

I think if this is done, the whole scope thing gets pretty useless so it can probably be removed entirely and instead be implemented as a separate window. Maybe add a scope mode in spectrum analyzer.

Sti2nd commented 10 years ago

And maybe someone is willing to update the scope to stereo scope :sunflower:

tobydox commented 10 years ago

FYI: the current scope is stereo already :-)

musikBear commented 10 years ago

how will this look in 4:3? i have to say that i like a left aligned toggle-group At least release a RC (for look feel tests) before commiting to this design in 1.0

diizy commented 10 years ago

On 02/28/2014 06:11 PM, musikBear wrote:

how will this look in 4:3? i have to say that i like a left aligned toggle-group At least release a RC (for look feel tests) before commiting to this design in 1.0

This won't go to 1.0.0.

Sti2nd commented 10 years ago

I mean SURROUND scope :hand:

tresf commented 10 years ago

how will this look in 4:3?

This depends on the pixel width of the 4:3 screen, but assuming the proposal is used, the items would overflow into a second line (in the case of the buttons, I would advise overflowing half (6 buttons), but that is highly dependent on the flow layout used) as described here:

Make the file and project toolbar buttons a single row that is capable of overflowing into a second row if needed.

-Tres

tresf commented 10 years ago

I spent some time looking into the overflow capabilities in QT in terms of the toolbar and they look quite involved compared to some other layout managers I've used since QT seems to lack a layout manager that does automatic overflow.

What I did discover was a QT sample FlowLayout that allows this automatic "overflowing": Not sure if it's the right approach, but i wanted to offer it for reference from the qt docs:

I would assume this layout manager could help in quite a few areas that have naturally forced minimum-width constraints due to child elements (i.e. toolbars); particularly helping with the increasing minimum width of the Piano Roll.

Sample Screenshot:

image

FlowLayout Example:

http://qt-project.org/doc/qt-4.8/layouts-flowlayout.html

FlowLayout Source Code:

http://qt-project.org/doc/qt-4.8/layouts-flowlayout-flowlayout-cpp.html http://qt-project.org/doc/qt-4.8/layouts-flowlayout-flowlayout-h.html

Files for reference:

/src/gui/MainWindow.cpp
/include/MainWindow.h

-Tres

diizy commented 10 years ago

On 03/04/2014 11:21 PM, Tres Finocchiaro wrote:

I spent some time looking into the overflow capabilities in QT in terms of the toolbar and they look quite involved compared to some other layout managers I've used.

What I did discover was a QT sample FlowLayout that allow this "overflowing": Not sure if it's the right approach, but i wanted to offer it for reference from the qt docs:

http://qt-project.org/doc/qt-4.8/layouts-flowlayout.html

http://qt-project.org/doc/qt-4.8/layouts-flowlayout-flowlayout-cpp.html
http://qt-project.org/doc/qt-4.8/layouts-flowlayout-flowlayout-h.html

Yeah that's probably the way to go, but that's for after 1.0.0. Now we're in bughunt mode.