LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.98k stars 994 forks source link

i18n: one string appears to be non-translatable #4017

Open trebmuh opened 6 years ago

trebmuh commented 6 years ago

In plugins/ladspa_browser/ladspa_browser.cpp line 51, the string "LADSPA Plugin Browser" is not translatable. I don't know how to make it so, then I'm opening this Issue rather than making a Pull Request. If someone tells me how to do so, I'm happy to send a PR.

PhysSong commented 6 years ago

The display name isn't translatable for any other plugins. If you still want to translate this, however, you may wrap that with QT_TRANSLATE_NOOP as well as the description.

I guess you want to translate Tools>LADSPA Plugin Browser. Right?

trebmuh commented 6 years ago

@PhysSong : thanks.

The display name isn't translatable for any other plugins. If you still want to translate this, however, you may wrap that with QT_TRANSLATE_NOOP as well as the description.

OK, see https://github.com/LMMS/lmms/pull/4019 , am I done correct?

I guess you want to translate Tools>LADSPA Plugin Browser. Right?

Yes.

trebmuh commented 2 years ago

any news here?