The Instrument window GUI needs refactoring

[raindropsfromsky]

The layout of the instrument window does not reflect its functionality, in several places. This can be confusing to new users.

The layout can be streamlined as follows:

Part-1: Relocation of the filter section:

In the instrument window, the sound processing is as follows:

Essentially, the user sets the instrument in two (optional) steps:

1. He applies envelope and LFO to the volume of the channel.
2. Then he selects a filter, and then applies envelope and LFO to its cut off and resolution parameters.

But this is not correctly reflected in the GUI. Here, the user selects the second tab marked Then he selects one of three sub-tabs:

At this stage, the rest of the GUI (till the end) must be related to his chosen combination. But that's actually NOT the case: The filter section is common for all three sub-tabs.
You are not supposed to select three filters (a distinct filter for each sub-tab)!

Therefore the filter section must be moved above the three sub-tabs, as shown below.

Part-2: The Keyboard can be shifted to a much more logical place!

The pitch keyboard section (reference pitch key) is also not related to any of the three sub-tabs. (In fact, it is not related to any of the other main tabs also). Therefore, there is no need to attach the "keyboard" (Instrument's pitch) section to the bottom of the Instrument window.

Secondly, the pitch of the instrument is not changed so often. So we do not need to keep the keyboard so conspicuously accessible at all times. It can be tucked away in one of the tabs.

In fact, the best place for this widget is in the last tab, where there is already an option to disable the master pitch. Thus the same page should hold the controls for the instrument's pitch also!

BTW if this change is implemented, change the symbol for this tab from "miscellaneous" to "Pitch"

[Spekular]

The keyboard doesn't just change the base note, it can also be played with mouse and displays what note is being played if another input is being used.

Your proposed logo doesn't represent what the final tab is intended to be (miscellaneous options) and would not translate well to the small size the icons are at.

Finally, while your suggestions may or may not be valid (I won't weigh in here), I disagree with framing them as things that need to be done. Changes like these aren't something one person decides upon by themself.

On Jan 18, 2018 10:14, "Narayan" notifications@github.com wrote:

The layout of the instrument window does not reflect its functionality, in several places. This can be confusing to new users.

The layout can be streamlined as follows: Part-1: Relocation of the filter section:

In the instrument window, the sound processing is as follows: [image: image] https://user-images.githubusercontent.com/9047168/35087304-c483372c-fc55-11e7-935d-5c7f8b6884db.png

Essentially, the user sets the instrument in two (optional) steps:

1. He applies envelope and LFO to the volume of the channel.
2. Then he selects a filter, and then applies envelope and LFO to its cut off and resolution parameters.

But this is not correctly reflected in the GUI. Here, the user selects the second tab marked [image: image] https://user-images.githubusercontent.com/9047168/35087877-afd08968-fc57-11e7-99d0-bf45c1c78f12.png Then he selects one of three sub-tabs: [image: image] https://user-images.githubusercontent.com/9047168/35087903-c5e97ed0-fc57-11e7-89ee-c16cec29e752.png

At this stage, the rest of the GUI (till the end) must be related to his chosen combination. But that's actually NOT the case: The filter section is common for all three sub-tabs. You are not supposed to select three filters (a distinct filter for each sub-tab)!

Therefore the filter section must be moved above the three sub-tabs, as shown below. [image: image] https://user-images.githubusercontent.com/9047168/35088115-97a94888-fc58-11e7-8db8-bc3bd734b312.png Part-2: The Keyboard can be shifted to a much more logical place!

The pitch keyboard section (reference pitch key) is also not related to any of the three sub-tabs. (In fact, it is not related to any of the other main tabs also)

Secondly, there is no need to attach the "keyboard" (Instrument's pitch) section to the bottom of the Instrument window, as the pitch of the instrument is not changed so often.

In fact, the best place for this widget is in the last [image: image] https://user-images.githubusercontent.com/9047168/35088842-09210832-fc5b-11e7-9047-e2421ec5f2f1.png tab, where there is already an option to disable the master pitch. Thus the same page should hold the controls for the instrument's pitch also!

[image: image] https://user-images.githubusercontent.com/9047168/35088802-e338d96a-fc5a-11e7-86a5-a75fcd4144bf.png

BTW change the symbol for this tab from [image: image] https://user-images.githubusercontent.com/9047168/35088842-09210832-fc5b-11e7-9047-e2421ec5f2f1.png to [image: image] https://user-images.githubusercontent.com/9047168/35088951-6b5c5d76-fc5b-11e7-9017-2c53dcf6d6ab.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LMMS/lmms/issues/4122, or mute the thread https://github.com/notifications/unsubscribe-auth/AIgVmiwzO5B4Qs-5p7bREiqFR9WM2hQhks5tLwttgaJpZM4Rimpf .

[Spekular]

Actually I suppose I've already weighed in on this, in my previous message and I'll add on to that:

The envelope settings are surrounded by a border. The selection between volume/cutoff/resonance is inside this border. The filter selection is inside a separate border. This signifies that these are two separate subsections of the tab, hence there is no implication that three separate filters would be selected.

So personally, I disagree with these changes.

On Jan 18, 2018 10:50, "Spekular R" spekularr@gmail.com wrote:

The keyboard doesn't just change the base note, it can also be played with mouse and displays what note is being played if another input is being used.

Your proposed logo doesn't represent what the final tab is intended to be (miscellaneous options) and would not translate well to the small size the icons are at.

Finally, while your suggestions may or may not be valid (I won't weigh in here), I disagree with framing them as things that need to be done. Changes like these aren't something one person decides upon by themself.

On Jan 18, 2018 10:14, "Narayan" notifications@github.com wrote:

The layout of the instrument window does not reflect its functionality, in several places. This can be confusing to new users.

The layout can be streamlined as follows: Part-1: Relocation of the filter section:

In the instrument window, the sound processing is as follows: [image: image] https://user-images.githubusercontent.com/9047168/35087304-c483372c-fc55-11e7-935d-5c7f8b6884db.png

Essentially, the user sets the instrument in two (optional) steps:

1. He applies envelope and LFO to the volume of the channel.
2. Then he selects a filter, and then applies envelope and LFO to its cut off and resolution parameters.

But this is not correctly reflected in the GUI. Here, the user selects the second tab marked [image: image] https://user-images.githubusercontent.com/9047168/35087877-afd08968-fc57-11e7-99d0-bf45c1c78f12.png Then he selects one of three sub-tabs: [image: image] https://user-images.githubusercontent.com/9047168/35087903-c5e97ed0-fc57-11e7-89ee-c16cec29e752.png

At this stage, the rest of the GUI (till the end) must be related to his chosen combination. But that's actually NOT the case: The filter section is common for all three sub-tabs. You are not supposed to select three filters (a distinct filter for each sub-tab)!

Therefore the filter section must be moved above the three sub-tabs, as shown below. [image: image] https://user-images.githubusercontent.com/9047168/35088115-97a94888-fc58-11e7-8db8-bc3bd734b312.png Part-2: The Keyboard can be shifted to a much more logical place!

The pitch keyboard section (reference pitch key) is also not related to any of the three sub-tabs. (In fact, it is not related to any of the other main tabs also)

Secondly, there is no need to attach the "keyboard" (Instrument's pitch) section to the bottom of the Instrument window, as the pitch of the instrument is not changed so often.

In fact, the best place for this widget is in the last [image: image] https://user-images.githubusercontent.com/9047168/35088842-09210832-fc5b-11e7-9047-e2421ec5f2f1.png tab, where there is already an option to disable the master pitch. Thus the same page should hold the controls for the instrument's pitch also!

[image: image] https://user-images.githubusercontent.com/9047168/35088802-e338d96a-fc5a-11e7-86a5-a75fcd4144bf.png

BTW change the symbol for this tab from [image: image] https://user-images.githubusercontent.com/9047168/35088842-09210832-fc5b-11e7-9047-e2421ec5f2f1.png to [image: image] https://user-images.githubusercontent.com/9047168/35088951-6b5c5d76-fc5b-11e7-9017-2c53dcf6d6ab.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LMMS/lmms/issues/4122, or mute the thread https://github.com/notifications/unsubscribe-auth/AIgVmiwzO5B4Qs-5p7bREiqFR9WM2hQhks5tLwttgaJpZM4Rimpf .

[raindropsfromsky]

The keyboard doesn't just change the base note, it can also be played with mouse and displays what note is being played if another input is being used.

This can be done even after shifting the keyboard section. Finally, the main use of the keyboard is to match the pitch with another instrument.

At present, there is no other part of the window that needs to be viewed (like viewing two separate controls in a dashboard together to take decisions) along with the keyboard.

Your proposed logo doesn't represent what the final tab is intended to be (miscellaneous options) and would not translate well to the small size the icons are at.

I also felt that. Well, my point was not about the symbol per se. It should be changed from "miscellaneous" to something related to "pitch".

I disagree with framing them as things that need to be done.

Well, any issue posted at GitHub is an opinion. If there is a protocol about specific way to express the issues, please share the link. I would be glad to follow the best practices in any community.

The envelope settings are surrounded by a border. The selection between volume/cutoff/resonance is inside this border. The filter selection is inside a separate border.

Well, the frame is designed in such a way that it is not easy to tel them apart. The filter does look like part of the tab (thus it appears like we have access to three separate filters-- One on each tab).

In any case, shifting the filter up kills this ambiguity altogether.

[raindropsfromsky]

Another logical thing to do is first select a filter and then apply env/LFO to it; not first apply env/LFO to "something" and then define what that "something" is.

[Anonymouqs]

Personally, the Keyboard should be kept so you don't have to switch tabs to test your sound. What if someone wants to use a touch interface on LMMS? I know you can use the keyboard to test, but instead, what if we allowed the user to "stow away" the piano keyboard? So when they don't need it, it's out of sight, out of mind. But they can still use it while having a settings tab open.

[tresf]

@Anonymouqs, rest assured, this keyboard won't be moved or removed in the foreseeable future.