LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.13k stars 1.01k forks source link

Noticeable delay when using TAP Vibrato #4143

Open ghost opened 6 years ago

ghost commented 6 years ago

When using the bundled TAP Vibrato effect the sound is consitently delayed by a split second.

Steps to reproduce

  1. Load any project
  2. Add a TAP Vibrato effect with the following settings.

Expected behaviour: a vibrato is applied to the sound.

Actual behaviour: the vibrato is indeed applied, but accompanied with a delay.

Sample project file, which renders to this.

zonkmachine commented 6 years ago

I can't replicate this on stable-1.2 but maybe you're on master?

Did you compile this yourself? git status output?

tresf commented 6 years ago

lmms -d ~/Downloads/tap_vibrato.mmpz |grep creatorversion says 1.2.0-rc5.9 although this could be stable-1.2 or master.

ghost commented 6 years ago

Yes, it's a custom build.

Output of git status:

On branch stable-1.2
Your branch is up to date with 'origin/stable-1.2'.

nothing to commit, working tree clean

Output of git log -n1:

commit 27007c258a7b83b8fb89bea753c9b4d767686ef3 (HEAD -> stable-1.2, origin/stable-1.2, origin/HEAD)
Author: Dominic Clark <mrdomclark@gmail.com>
Date:   Fri Jan 26 15:48:46 2018 +0000

    Fix command line rendering with VSTs (#4093)

    Fix command line rendering with VSTs

This is an issue I've been having since I first started using LMMS a year or so ago, however.

musikBear commented 6 years ago

win32 rc5 -well there is a delay: vibratordelay It is tiny, but it is a delay..

zonkmachine commented 6 years ago

Sample project file,

By a split second, yes. In the provided file you have setting wet/dry 1.0 on the BitInvader Effects Chain and no dry signal, meaning all wet, on the TAP plugin too. Since vibrato is a delay based effect, either a plain delay or some phasing stages, there should be a bit of a delay with no clean signal. I would expect an altering delay that would differ depending on where in the LFO cycle we're in. Could this be the delay you're seeing?

musikBear commented 6 years ago

Since vibrato is a delay based effect, either a plain delay or some phasing stages, there should be a bit of a delay with no clean signal

I thought the same, but did not 'know' -I think that is exactly what my picture shows : mSec 'delay' -Can OP make a similar picture of the noticeable delay he has? @difarem

ghost commented 6 years ago

From the OGG I posted:

tresf commented 6 years ago

@difarem can you test the plugin in another editor such as Audacity? If it exists there too, you will have to file a bug report with Tom Szilagyi over at https://github.com/tomszilagyi/tap-plugins/issues. LADSPA plugins are not written by LMMS Developers, we take them all from their upstream mirrors and bundle them as a courtesy.

ghost commented 6 years ago

https://i.imgur.com/TaFW1hz.png

By the looks of it, the delay is longer on the bundled LMMS version. Not by much though. Should I proceed closing this issue?

zonkmachine commented 6 years ago

I get 60ms delay in both lmms and audacity with 0% dry signal. I don't know what a vibrato effect usually has but it sounds a bit high. A quick search gave me the tc electronic Shaker Vibrato guitar pedal which sweeps from 0-20ms delay.