Undo not working properly in Song editor

jibin1573 commented 6 years ago

Several song editor actions cannot be undone (Checklist courtesy of @allejok96)

[x] Undo insert bar #6347
[x] Undo track color change #6165
[ ] Undo copy paste of multiple clips #6410

Original bug report

Using Windows 10 LMMS 1.2.0 RC6 I opened a song project, and took the playhead to the start of the song and then pressed Shift+Insert key to add 5 empty bars; then I tried to undo it, but there is no response at all! LMMS is unable to undo this. (Also note that, I went through the above mentioned steps directly after opening the project, so there is nothing else to be undone. And also, I have tried this with a completely different project, but Undo is not working.)

jibin1573 commented 6 years ago

I have encountered another problem with Undo. Recently, I opened a project and changed the colour of a BB track in the Song editor and tried to undo this, but there is no response.

steven-eckhoff commented 6 years ago

I am interested in looking into this. Is anyone else working on it?

SecondFlight commented 6 years ago

I don't believe so. It's all yours if you want it! @PhysSong this would be a good thing to base off stable1.2, correct?

steven-eckhoff commented 6 years ago

Okay I will take a look then.

Also I was going to ask about an architecture doc for guidance about the expected behavior and I found this [1]. It looks like it is limited at the moment, so I will just ask questions here.

[1] https://github.com/LMMS/lmms/wiki/LMMS-Architecture

tresf commented 6 years ago

@Anonymouqs can you please consolidate all "Undo" related bugs into one meta issue for us with a checkbox next to each?

@steven-eckhoff feel free to post any updated here or -- once created -- in the meta bug report.

oldcastlehq commented 3 years ago

I'm not sure if I'm supposed to add anything else here, but the issues with undo in Song Editor still there. Any development here?

musikBear commented 3 years ago

@oldcastlehq What issue specific? And please post your:

Name of your Operative System (Windows/ Linux/ Mac) And subtype (Home' 'Mint' '10.13' aso)
lmms version and the site where you got it from

oldcastlehq commented 3 years ago

@musikBear

Operating System: Manjaro Linux KDE Plasma Version: 5.21.4 KDE Frameworks Version: 5.81.0 Qt Version: 5.15.2 Kernel Version: 5.10.34-1-MANJARO OS Type: 64-bit Graphics Platform: X11 Processors: 8 × Intel® Core™ i7-8565U CPU @ 1.80GHz Memory: 15,5 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 620

I'm using https://aur.archlinux.org/packages/lmms-git/
The problem seems to be the same as described here. For example. I open a project and select half of the track. I use the mouse to drag the selected half to the right. Now, after releases the mouse, I want to undo my action. The undo does't work.

qnebra commented 3 years ago

I guess not all operations in Song Editor are indexed.

For me it doesn't work properly too. Create new pattern, clone it by Ctrl+drag original pattern, select both patterns, move into new position and press Ctrl+Z. Copy of pattern created with Ctrl+drag gets deleted. If you use Copy and Paste it doesn't get deleted.

musikBear commented 3 years ago

Aaa.. Looks like this is a LINUX thing. Are you both on appImage-Off (1.2.2) That was not answered :) @qnebra, Can you write a bug summery with the proper structure and content, if this indeed is Off appImage?

oldcastlehq commented 3 years ago

@musikBear no appimage here.

musikBear commented 3 years ago

@musikBear no appimage here.

That is wrong! The only linux version that is official, is appImage It is this one: https://github.com/LMMS/lmms/releases/download/v1.2.2/lmms-1.2.2-linux-x86_64.AppImage You should follow the version-update-guide: https://lmms.io/wiki/index.php?title=Installing_LMMS#Updating_and_installing_new_versions and upgrade to 1.2.2 Off. Then retry the bug-issue, however qnebra will already have done that, i hope.. -But for you the off version should replace the one you have now, if you want to have best non-alpha installed.

oldcastlehq commented 3 years ago

I think there is a misunderstanding here. I'm using 1.3 alpha. This is a compiled version using AUR from Arch Linux https://aur.archlinux.org/packages/lmms-git/.

The issue described here, still there.

musikBear commented 3 years ago

I think there is a misunderstanding here. I'm using 1.3 alpha. This is a compiled version using AUR from Arch Linux https://aur.archlinux.org/packages/lmms-git/.

The issue described here, still there.

Ok, so its a Master 1.3 issue, and not in off. release. Over and out..

rdrpenguin04 commented 3 years ago

Ok, so its a Master 1.3 issue, and not in off. release. Over and out..

@musikBear Feel free to shut it; this is a legitimate problem, especially if it's on the latest source-built versions.

Anyways, no idea what the status of this is. Could we get a report from whoever is in charge of this now?

musikBear commented 3 years ago

Nonono should not be closed! Its just that the version info was missing, because this was added to a very old issue, so the form used for reporting bugs was not available -No, good report!

allejok96 commented 2 years ago

There are multiple examples mentioned here, one is fixed and two is pending.

[x] Undo insert bar #6347
[x] Undo track color change #6165
[ ] Undo copy paste of multiple clips #5920

Note that undo system is still full of holes and needs to be reworked. That's a topic for another issue.

Rossmaxx commented 3 months ago

Re milestone ing till someone takes over #6410

LMMS / lmms

Undo not working properly in Song editor #4471