Improvements for the selection tool

Gabrielxd195 commented 6 years ago

Hi guys, how are you? As I said in other threads, I have been using lmms lately and while I have used it, I have found some minimal errors. (apparently irrelevant) but that make it more difficult to use in lmms.

Some of these errors have the selection tools. selector no borra en grupo modificada

Here I mention the errors and improvements of the selection in general in all the editors

Song Editor

[x] Delete clips grouped with the selection tool by pressing "delete" in the song editor. (#3649)
[ ] Select the desired parts of a clip, instead of selecting the entire clip.
[ ] Free selection in the song editor.
[ ] Inverted selection in the song editor.
[ ] Select multiple tracks in the song editor with selection tool or by pressing "Ctrl".

Beat Bassline

[ ] Selection tool in the bb editor.
[ ] Free selection of notes in the bb editor.
[ ] Inverted selection in bb editor.

Piano Roll

[ ] Free selection on the piano roll.
[ ] Inverse selection of notes on the piano roll.
[ ] Multiple selection of midi notes by pressing "Ctrl" inside the piano roll.

Automation editor

[ ] Selection tool in the automation editor.
[ ] Free selection of automation points.
[ ] Inverted selection in the automation editor
[ ] Multiple selection of automation points by pressing "Ctrl".

Sample Track

[ ] Select the desired wave parts of the sample track.
[ ] Select free in the wave of the sample track.
[ ] Select inverted in the wave of the sample track.

Mixer FX

[ ] Selection tool within the fx mixer.
[ ] Select multiple channels by pressing "Ctrl".
[ ] Select multiples in the effects window by pressing "Ctrl".
[ ] Free selection in the channels and effects.

File Browser

[ ] Multiple file selection by pressing "Ctrl".
[ ] Selection tool in the file browser.

So far are the problems I've seen both the selection tool and the selection in general, maybe they are minimal errors, but they are very annoying and waste time. it does not always work by pressing "Ctrl". Greetings.

musikBear commented 6 years ago

@Gabrielxd195 First - Are you on 1.1.3? Please update to 1.2.0 RC6 (orange buttons) https://lmms.io/download/#windows Then retry your fail-collection. block-deletes are fixed in RC, so many of your fails are fixed already

Gabrielxd195 commented 6 years ago

no friend, I am in version 1.2.0 rc6, what happens is that you can not see the title bar. the selection errors are still valid This photo is from lmms is from the latest version, and that is why I put my suggestions.

musikBear commented 6 years ago

....Oh dear. Block-deletes are lost in RC6. In RC4 it works perfectly. (win 32) -a re-introduced bug. 😭

jibin1573 commented 6 years ago

This has been implemented for version 1.3, where pressing the Delete key deletes selected blocks.

Implemented in master via #3649.

Please close the issue if this (#3649) is what you wanted.

SecondFlight commented 6 years ago

@jibin1573, thanks for pointing that out.

@Gabrielxd195, do the fixes in #3649 describe your issue?

jibin1573 commented 6 years ago

This was actually pointed out by @sawuare, when he closed my issue #4470.😀

musikBear commented 6 years ago

@jibin1573 writes: > This has been implemented for version 1.3

I repeat: it works in RC4 win 32

tresf commented 6 years ago

Implemented in master via #3649.

I repeat: it works in RC4 win 32

@musikBear not on 1.2.0-RC7 for me (MacOS) and that's OK. We can stage this for 1.3.0.

@BaraMGB #3649 doesn't seem to work properly with Undo. It gets journaled as multiple events instead of one single event. Is that desired? It also doesn't work with the right-click context menu at all. Just deletes the pattern under the keyboard.

We also need to find a way to refactor this for MacOS. There's no "DEL" key on a Mac keyboard, we should entertain using Backspace instead.

@Gabrielxd195 please try to keep your bug reports and enhancements filed separately. Please edit the bug report to reflect that it's "better selection tool behavior" and then use checkboxes to represent each enhancement. If you don't clean it up, I'll close it out as a duplicate of #3649 as master branch has the issue described in the title working.

For an example of a "meta" issue, please see here: https://github.com/LMMS/lmms/issues/1472

Also, please read #3649 carefully so that you can explicitly mark stuff that's already coded in master. In the future, if you don't research before filing a bug, we'll close it out. This tracker can't be used as a dumping ground for every feature request.

BaraMGB commented 6 years ago

@tresf as I mentioned in https://github.com/LMMS/lmms/pull/3649 I don't know how to fix the undo system. In the moment I stuck in a other project. I hope I can get back to lmms development in a few weeks.

Btw: I feel https://github.com/LMMS/lmms/pull/3649 could be a good candidate for backporting in 1.2. Working with this in songeditor is so much easier. Of course we should fix the Mac issues at first.

tresf commented 6 years ago

Btw: I feel #3649 could be a good candidate for backporting in 1.2. Working with this in songeditor is so much easier. Of course we should fix the Mac issues at first.

The goal is to get 1.2.0 out the door and offer nightly "1.3.0" releases shortly following.

Gabrielxd195 commented 6 years ago

Implemented in master via #3649.

I repeat: it works in RC4 win 32

@musikBear not on 1.2.0-RC7 for me (MacOS) and that's OK. We can stage this for 1.3.0.

@BaraMGB #3649 doesn't seem to work properly with Undo. It gets journaled as multiple events instead of one single event. Is that desired? It also doesn't work with the right-click context menu at all. Just deletes the pattern under the keyboard.

We also need to find a way to refactor this for MacOS. There's no "DEL" key on a Mac keyboard, we should entertain using Backspace instead.

@Gabrielxd195 please try to keep your bug reports and enhancements filed separately. Please edit the bug report to reflect that it's "better selection tool behavior" and then use checkboxes to represent each enhancement. If you don't clean it up, I'll close it out as a duplicate of #3649 as master branch has the issue described in the title working.

For an example of a "meta" issue, please see here: #1472

Also, please read #3649 carefully so that you can explicitly mark stuff that's already coded in master. In the future, if you don't research before filing a bug, we'll close it out. This tracker can't be used as a dumping ground for every feature request.

Good night. Update my bug report, I hope it meets your expectations. I do not use github nor am I a developer, I just like lmms and I want to cooperate at least giving suggestions. regards

BaraMGB commented 5 years ago

@Gabrielxd195 can you elaborate more what you mean by "free selection in song editor"?

Spekular commented 5 years ago

Also

"Select multiple tracks in the song editor with selection tool or by pressing "Ctrl"." is already fixed in master since #3649 was merged
I don't think "Select the desired parts of a clip, instead of selecting the entire clip." makes any sense. The only way I can imagine this working is cutting clips at the box selection boundary, whoch sounds terrible imo.
Nothing under "Beat Bassline" makes sense to me.
"Multiple selection of midi notes by pressing "Ctrl" inside the piano roll." In my experience, selection shortcuts tend to deselect before making the new selection, and shift+select is used to add a new selection to the existing one. However, isn't ctrl+shift used for inverted selection somewhere in LMMS?
Automation editor can, imo, be consolidated into "Selection tool in automation editor"
Sample track section doesn't make sense to me. Selecting parts of a sample seems like the job of the knife tool and/or left/right resize to me (clone the whole clip and then trim, or cut into sections firsrt and then clone the desired one)
Multiple selection in the file editor doesn't make sense in any usecase I can think of. You can only load one file into AFP/VeSTige/etc., and load one project into an LMMS instance. Automatically creating several new tracks or opening new copies of LMMS to accomodate selecting multiple files doesn't seem like a good idea.

musikBear commented 5 years ago

I don't think "Select the desired parts of a clip, instead of selecting the entire clip." makes any sense.

Agree. And the right way to go would be a new method to split the TCO, then use the normal select.

However, isn't ctrl+shift used for inverted selection somewhere in LMMS?

Afaik inverting selections has not been implemented

opening new copies of LMMS to accomodate selecting multiple files doesn't seem like a good idea.

I could see a way to 'borrow' a named part in a different file, but that should not lead to fully loading of the 'donor' project. In fact it could be as simple as read-copy a specified section in the donor-project-mmp, and a paste in the receiving-project, followed by a reload.

zonkmachine commented 4 years ago

@Gabrielxd195 can you elaborate more what you mean by "free selection in song editor"?

@Gabrielxd195 I wonder this too. What does 'free selection' mean?

* However, isn't ctrl+shift used for inverted selection somewhere in LMMS?

@Spekular Maybe you're thinking of Ctrl + Shift + A, which deselects all selected notes? Same as Esc. I'm testing inverting selection in the Piano Roll Editor and I'm using Ctrl + Shift + I.

LMMS / lmms