LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.81k stars 986 forks source link

Export MIDI: tempo change events #4765

Open tukkek opened 5 years ago

tukkek commented 5 years ago

Not sure if this is a bug report or a feature request but if you have an automation track changing the tempo of a composition, the exported MIDI file will not carry with it the appropriate MIDI tempo change event.

I imagine automation is entirely disregarded during the export process but considering MIDI supports a tempo change event, it might be relatively simple to support this particular feature (maybe even through a hack that keeps track if the tempo has changed since the last beat or something).

Thanks for the amazing work on LMMS! As if it wasn't already my music production suite of choice, you guys keep making it even better! The MIDI export is godly!

SecondFlight commented 5 years ago

Hi tukkek, thanks for the suggestion.

I would say this is a feature request as opposed to a bug, as it's almost certainly going to require adding new functionality instead of fixing something that's broken.

tukkek commented 5 years ago

I fully understand your point of view but keep in mind that to anyone exporting a project that has tempo changes, this is definitely a bug since the song is not exported correctly. Please consider this fact as well.

Thanks again!

musikBear commented 5 years ago

naehh this is simply because the import of midifiles leaves a tempi-stamp in the midi-code. @tukkek Try this:

Was that it?

Spekular commented 5 years ago

That's not what this issue is about @musikBear. OP is asking for MIDI exported from LMMS to include tempo automations.

On Thu, Jan 10, 2019, 14:18 musikBear <notifications@github.com wrote:

naehh this is simply because the import of midifiles leaves a tempi-stamp in the midi-code. @tukkek https://github.com/tukkek Try this:

  • Open the project in question, and right-click the BPM-gadget
  • from context-menu select "remove-all-global-automation"
  • make you BPM changes in the again
  • export

Was that it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LMMS/lmms/issues/4765#issuecomment-453092882, or mute the thread https://github.com/notifications/unsubscribe-auth/AIgVmqakbzIhciXeRoZok-Ffc6hsMWMaks5vBz2mgaJpZM4Z10uH .

musikBear commented 5 years ago

My bad -sorry

atirut-w commented 4 years ago

This issue report is mildly confusing

SecondFlight commented 4 years ago

What do you find confusing here? Tempo automation doesn't work with MIDI export:

If you have an automation track changing the tempo of a composition, the exported MIDI file will not carry with it the appropriate MIDI tempo change event.

EFHIII commented 4 years ago

Not having this as a feature is really frustrating for me right now since I need to make heavy use of MIDI export. Another note; it seems that LMMS screws with imported MIDI tempos; normalizing everything to integer tempos and placing them on beats lines if I'm not mistaken which is completely ruining a timing sync I need for a game, not to mention making imported MIDIs not sound quite right when there's a dramatic tempo change on an off-beat from a slow BPM to fast.