LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.08k stars 1.01k forks source link

Dual Filter CPU spike problem #485

Closed mikobuntu closed 10 years ago

mikobuntu commented 10 years ago

@diizy Hi, great idea for a plugin by the way, I however have noticed it will max out my cpu mostly/especially whenever i choose the "formant filter" in any or both of the mix channels. I guess the formant filter is more complex and does generally require more cpu , but it should not max out especially on a basic test with one note on a triple_osc in the bb_editor..

thanks Mikobuntu

diizy commented 10 years ago

On 03/19/2014 02:31 AM, mikobuntu wrote:

@diizy https://github.com/diizy Hi, great idea for a plugin by the way, I however have noticed it will max out my cpu mostly/especially whenever i choose the "formant filter" in any or both of the mix channels. I guess the formant filter is more complex and does generally require more cpu , but it should not max out especially on a basic test with one note on a triple_osc in the bb_editor..

thanks Mikobuntu

The formant filter indeed takes a lot of cpu power.

Using a single formant filter shouldn't take any more cpu than what it does on the ENV/LFO tab though. Is the usage higher than what it is on the ENV/LFO tab? I might have to implement some checks to ensure the filter coefficients aren't recalculated needlessly.

mikobuntu commented 10 years ago

yes it takes up a lot more cpu than the ENV/TAB , it will just spike and cut out my audio until it is either disabled by the on/off switch or deleted

thanks Mikobuntu

diizy commented 10 years ago

Ok, should be better once that commit gets merged.