search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.98k stars 995 forks source link

lmms 1.2.0: text relocation in /usr/lib/lmms/RemoteVstPlugin.exe.so #5024

Open dvzrv opened 5 years ago

dvzrv commented 5 years ago

When building lmms 1.2.0 for Arch Linux, our package check tool namcap reports text relocations in /usr/lib/lmms/RemoteVstPlugin.exe.so: 

lmms W: ELF file ('usr/lib/lmms/RemoteVstPlugin.exe.so') has text relocations.

Is that library build with -fPIC?

tresf commented 5 years ago

Related #4806.

No, I don't think so. Looking back at the codebase, I believe the whole project used to be in 2006, but must have gotten refactored out at some point.

From what I'm reading, all plugins should build with this flag. Do you get more of these? If not, it may be due to the fact that we compile this particular plugin by hand instead of using whatever defaults that cmake uses. Long term, we should convert this to ExternalProject_Add instead.

PhysSong commented 5 years ago

Long term, we should convert this to ExternalProject_Add instead.

IIRC, @lukas-w refactored RemoteVstPlugin build logic to use that in #4421.