search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.83k stars 988 forks source link

ZynAddSubFX "Scales" feature reverts to 12TET when using ratios instead of cents #5092

Open LostRobotMusic opened 4 years ago

LostRobotMusic commented 4 years ago

Tested in latest master and RC6 master, I'm pretty sure it's present in all LMMS versions.

ZynAddSubFX has a "Scales" section where you can change the scale to allow microtonality/xenharmonics and stuff like that. The box on the left of that window lets you enter in ratios or cent values to apply to the matching note. Within ZynAddSubFX, everything works/plays fine, but as soon as you close the ZynAddSubFX GUI, every note that was tuned using ratios rather than cents is reverted to the normal 12TET scale. If cents are used, everything works properly.

For example, "536.00" would work, while something like "7/4" would revert to 12TET when ZynAddSubFX's GUI is closed.

JohannesLorenz commented 4 years ago

Btw, this should probably be fixed with plugin APIs like Lv2 or SPA, since closing the new zyn-fusion UI has no effect on the rest (separate processes). The current ("old") zyn does a lot of stuff when you open/close a UI (including starting/exiting a separate whole zyn process), so maybe this gets lost when switching.