search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.06k stars 1k forks source link

Show knob value without clicking. #5779

Closed Gabrielxd195 closed 1 year ago

Gabrielxd195 commented 3 years ago

Summary of improvements

Show the value of the knob without clicking on it

Justification

When I want to know the value of a knob I have to click on it, but in some cases when I click, sometimes by accident I move the mouse and change the value of the knob.

I know that we have the option of '' reset '' to restore the default value, but it would be more practical if the knob will show its value just by hovering over it like the other icons and buttons of the interface.

Sketch

Here is an image of the problem. Mostrar el valor de la perilla al pasar el puntero

musikBear commented 3 years ago

Agree! And it ought to be a simple fix, if the super-class has an 'on-left-click-event'. Change that to on-mouse-over-event 'Off' could be an issue -though, unless there is a on-mouse-leave-event implemented. Only cravat i can see is a confusing flicker of values, as the mouse is moved over controllers, and that could be annoying. A short 'delay' before the tool-tip is displayed, would sort that(?)

PhysSong commented 3 years ago

To implement this, one need to show and place Knob::s_textFloat with a QTimer to prevent flickers.

salilra commented 3 years ago

I can take this issue, if no one is working on it.

justlog commented 2 years ago

Thought about trying my hand at contributing to the project and came across this. It seems as though @salilra implemented the fix but it's not merged as of yet. Is there any work to be done regarding this issue?

Rossmaxx commented 2 years ago

@salilra update? @justlog feel free to make your version.

Monospace-V commented 2 years ago

update?

https://github.com/LMMS/lmms/pull/5911

salilra commented 2 years ago

Sorry folks I haven't been able to find time to fix this in a while. If anyone wants to take over, feel free

AngeloSorte commented 2 years ago

I like this! I will try to give some help!

chaitanyak175 commented 1 year ago

Is anyone working on this issue I can give it a try as this will be my first time contributing to an open source project.

MrTopom commented 1 year ago

I could work on it...

zonkmachine commented 1 year ago

@MrTopom There seem to be an open PR for this issue. https://github.com/LMMS/lmms/pull/5911 I don't know what state it's in though.

zonkmachine commented 1 year ago

New comments in the PR https://github.com/LMMS/lmms/pull/5911