SVG images are broken on Windows installers

LMMS / lmms

Cross-platform music production software

https://lmms.io

GNU General Public License v2.0

8.18k stars 1.01k forks source link

SVG images are broken on Windows installers #5810

Open PhysSong opened 3 years ago

PhysSong commented 3 years ago

First reported: https://github.com/LMMS/lmms/pull/5160#issuecomment-545522520 In order to make SVG images working in LMMS from Windows installers and/or Linux AppImages, the Qt SVG library and corresponding image format plugin should be deployed. Currently, however, they are not.

AppImage: installing the Qt SVG library is sufficient, linuxdeployqt will take care of deployment(no development libraries required).
Windows: requires some CMake logic to bundle required DLLs, MinGW builds have an additional issues(the version of qt5svg-mingw-w64 doesn't match with qt5base-mingw-w64.).

PhysSong commented 3 years ago

Fixed AppImages from CircleCI via LMMS/lmms-ci-docker#9, but spectrum analyzer on Windows is still an issue.

Rossmaxx commented 3 months ago

@DomClark is there a chance transitioning to MSVC completely might fix the version inconsistency too? If not, what's the best route for a fix?

DomClark commented 3 months ago

We use the official Qt distribution (albeit not via the official installer) for MSVC builds, so exclusively using MSVC builds would avoid the version inconsistency, yes. However, we still plan to support MinGW builds, and I'm not aware of any reason that an appropriate version of qt5svg-mingw-w64 couldn't be built.

Rossmaxx commented 1 month ago

I'm moving this out of the milestone for now. If anyone feels this should be a part of 1.3, feel free to add back in.

he29-net commented 1 month ago

Should I perhaps look into adding a temporary workaround that replaces SVGs by bitmaps for Windows builds?

Having blurry or pixelated icons on Windows would probably be better than releasing a stable version with new spectrum analyzer full of randomly colored squares in place of a GUI. I have almost zero knowledge about our build system (let alone about Windows builds), so I can't really help with the underlying Qt SVG library issue.