LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.8k stars 986 forks source link

Record notes from a MIDI device should draw the notes as they are being played in the Piano Roll #6091

Open ghost opened 2 years ago

ghost commented 2 years ago

Bug Summary

Record notes from a MIDI device should draw the notes as they are being played in the Piano Roll. That way we'd have better feedback on when & where the note is being drawn.

Steps to reproduce

Open Piano Roll and click either of the record from MIDI buttons, start pressing and holding keys, the notes will pop in the view without any real feedback what note is being recorded and for how long except for the key highlight at the left side of the view.

Expected behavior

The notes to be smoothly drawn in the view in realtime. (See screenshot below)

Actual behavior

The notes just appear instantly at the moment.

Screenshot

Note drawing (from FL Studio's similar behavior)

Affected LMMS versions

1.2.2

Monospace-V commented 2 years ago

I don't know if adding this is a good idea, because I cannot see any practical use case unless latency is almost eliminated first, and this is probable to add latency to MIDI recording. But I do not know enough to say that with surety, since I speak only from what I already know of LMMS' MIDI recording.

zonkmachine commented 2 years ago

I don't think this would hit latency. At least not noticeably. The gui is (or should be) a separate thread. It would be a more intuitive experience.