search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.2k stars 1.01k forks source link

Loading mdaPiano causes audio spike #6161

Open Spekular opened 3 years ago

Spekular commented 3 years ago

Steps to reproduce

Master fader briefly hits red, as opposed to the expected complete silence. By itself this sounds like a click at worst, silence at best. Depending on the effects it runs through it can become loud and sustained (I accidentally ran it through Ambience reverb, which was very unpleasant).

Affected LMMS versions

1.2 and 1.3 alpha.

zonkmachine commented 3 years ago

I think this could be an issue with the mda vst. We fixed issues with mda piano in the lv2 version.

Monospace-V commented 3 years ago

I get a similar issue with Flygel. This also happens whenever you load a project with the VST in it. The more the instances of a VST causing this issue, the louder the click. This is prevented by muting the VSTs.

zonkmachine commented 3 years ago

@Spekular @Monospace-V You can try and add a waveshaper as first effect and just engage the Clip input button.

Monospace-V commented 3 years ago

Adding waveshaper and enabling clip input doesn't do anything, except perhaps reduce the volume of the click a bit. Extra note: Flygel has a very low audio spike upon loading, but when opening a project with Flygel there is a louder one.

zonkmachine commented 3 years ago

except perhaps reduce the volume a bit.

This is what I hoped for. Turn down the volume on your amp and see what the difference is with a reverb unit after the Waveshaper. It should get really loud without some clipping (toggle off) in there.

Monospace-V commented 3 years ago

That is what happens, yes. It gets insanely loud. (With the clipping enabled, it's still white noise, and still very obviously there, but doesn't spike to as loud as with clipping disabled.)

zonkmachine commented 3 years ago

Here is a fix for the lv2 version that looks like it could be related. https://gitlab.com/drobilla/mda-lv2/-/commit/c2d51675287343c9006256397ae50709ed2cc892 I don't think anyone push fixes upstream to the mda sourceforge page as it seem to be mostly unmaintained.

Monospace-V commented 3 years ago

Then is it unlikely the bug ever get fixed? (Also, because there are probably more VSTs causing this issue, LMMS could force mute upon import/load. eg, Flygel. The homepage itself doesn't seem to work, and it's impossible that Flygel ever be fixed.)

zonkmachine commented 3 years ago

Then is it unlikely the bug ever get fixed?

Never ever... Flygel is abandoned and closed source.

Also, because there are probably more VSTs causing this issue, LMMS could force mute upon import/load

Maybe something could be done to catch initial noise from a plugin, yes.

zonkmachine commented 7 months ago

Here is a fork of mda with updates https://github.com/pluginguru/mda-effects