LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
8.13k stars 1.01k forks source link

Fader/volume units in LMMS effects inconsistency- %, dB, dBFS, and dBv #6316

Open Monospace-V opened 2 years ago

Monospace-V commented 2 years ago

Bug Summary

Inconsistency in volume representation

  1. dB vs %

    When "display volume as dbFS" setting is disabled, volume should show in percentage values, the LMMS effects (like Equalizer, Compressor, Crossover equaliser) faders still show volume in decibels. While I can understand that things like Threshold (for compression) need to be in dB, and the equalizer's individual bands limit you to a -12 dB maximum meaning that 0% as the baseline value can be misleading, the main input/output gain faders go from +30 dB to -60 dB, which allows % to be used with reasonable straightforwardness (0% to 100% to 150% range, I believe, would be only slightly inaccurate). image image

I understand that the output gain knob at least for compressors is typically used for makeup gain and by extension preferable in the same volume unit as the threshold.

Also, multitap echo and spectrum analyzer, where volume representation is in dB. image image At least for the former, a percent representation of volume would make more sense for users with Display as dbFS disabled.

  1. volume units inconsistency within decibels

    It is possible I haven't listed all variations, because I use % values display, and dbFS display enabled may show me more, but: The gain on the equalizer's individual bands is in dB (decibels) The overall input/output gain on the equalizer is in dBv (decibel volts? Not entirely sure) The compressor and spectrum analyser's default units are, however, in dbFS (decibels relative to full scale)

(Also, on the multitap echo effect, image The + on the 0 annoys me to no ends because 0 is neither positive nor negative. It's an unnecessary character. This is just a slightly annoying minor thing, but it'd be very nice if it were fixed.)

zynskeywolf commented 2 years ago

Maybe not fully related to this problem, but I think dBFS should not be used as a unit in the first place. The only context it would be accepted is when setting an oscillator's amplitude. Any other volume slider/knob just adjusts a signal that already exists, therefore the correct unit would be dB. Just a small side note.