search

LMMS / lmms

Cross-platform music production software
https://lmms.io
GNU General Public License v2.0
7.83k stars 988 forks source link

Adding a "Dancer" like fruity Dance from FL Studio #6665

Open jtruji68 opened 1 year ago

jtruji68 commented 1 year ago

I made a functionality very similar to the chibi chick from FL Studio that dances to your main Song when its playing. Started as a joke but already works. It uses a Subwindow but frameless and transparent. I avoided messing with the base code the best I could so its integration could be easier. It uses the same sprite-sheet dimensions as the original Fruity dance so it should be themed as well (We can't use the same design I suppose). I tried it to make it a plugin but there was too much abstraction so I just made it as a regular window. This is the test output.webm I have to do quite the refactor and documentation first but if someone is already working on something like this I could help. Appreciate recommendations or as well. Forgot, if someone could please assign this to me as an enhancement.

AnotherBlob commented 11 months ago

Thank you, I need this. Has it been added so far and if so, what would it be called in LMMS?

jtruji68 commented 9 months ago

@AnotherBlob it has not been labeled as a enhancement and is still open so i guess the team is more focused now in bug fixing and new functionalities before looking for cosmetic ones. Well, I think we'll have to wait for a bit, and for the name I think we need even another mascot first because she belongs to FL lol.

Rossmaxx commented 9 months ago

and for the name I think we need even another mascot first

LoMMuS.

zonkmachine commented 9 months ago

i guess the team is more focused now in bug fixing and new functionalities before looking for cosmetic ones.

Correct, sorry for the late reply! We have a quite impressive backlog to process. I haven't used FL but this sound like a fun thing to add. One thing that I'm concerned with here is the artwork. When I look at your link at the top post and videos of the actual fruity dance plugin, they look practically the same.

(We can't use the same design I suppose)

Nope.

jtruji68 commented 9 months ago

@zonkmachine Dont worry, and thanks for your contributions to the project. Yes, is the same design i got from google images just for testing. Appreciate If anyone wants to design and draw a new original one, i made it compatible with the FL spritesheet as well. because I'm lacking at the art department.

zonkmachine commented 9 months ago

i made it compatible with the FL spritesheet as well. because I'm lacking at the art department.

I think that's possibly a problem too. It's part of the overall artwork. I'm unsure of graphic art legal matter as I've mostly been into sound and code. Someone else will have to look into this.

Spekular commented 9 months ago

I made a rough version of this a while ago. The way my implementation worked, the animation was stored as a folder containing images labelled with frame numbers. Any frame without a corresponding image would simply hold the latest frame. IMO this is nicer than having to make a spritesheet and duplicating frames if you want to animate on 2s/3s etc. for some parts of the sequence.

https://github.com/LMMS/lmms/compare/master...Spekular:lmms:ImageMetronome

jtruji68 commented 9 months ago

@Spekular that's pretty good. Which is better because I lost my code lol. We just need some artist that wants to make the design of the maskot. And some dev that wants to review the code for the pull request.